Audio codec usage statistics

webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

Index: webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h
diff --git a/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h b/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h
index 5ae6677cf9fd7f052f1dd42c0bd4e36209e9eb7f..1f23511bb925a1479e564544c449b7a25a8e823b 100644
--- a/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h
+++ b/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h
@@ -36,6 +36,8 @@ class AudioCodingModuleImpl final : public AudioCodingModule {
  public:
   friend webrtc::AudioCodingImpl;
 
+  static constexpr size_t kMaxAudioCodecNames = 64;

[ossu, 2016/05/12 12:50:14]

Maybe include something about logging in this name, since it's only for logging
purposes that this limit is applicable.

[kwiberg-webrtc, 2016/05/12 13:01:51]

In case some compiler (such as Visual Studio) complains that you need to put
this in the .cc file as well, try

  enum : size_t { kMaxAudioCodecNames = 64 };

instead.

[aleloi, 2016/05/12 13:25:47]

Added explaining comment and changed name to kMaxLoggedAudioCodecNames

+
   explicit AudioCodingModuleImpl(const AudioCodingModule::Config& config);
   ~AudioCodingModuleImpl() override;
 
@@ -295,6 +297,9 @@ class AudioCodingModuleImpl final : public AudioCodingModule {
   AudioPacketizationCallback* packetization_callback_
       GUARDED_BY(callback_crit_sect_);
   ACMVADCallback* vad_callback_ GUARDED_BY(callback_crit_sect_);
+
+  size_t codec_histogram_bins_log[kMaxAudioCodecNames];

[hlundin-webrtc, 2016/05/12 12:23:39]

Trailing underscore on member variables.

[aleloi, 2016/05/12 12:52:18]

Done.

+  size_t number_of_consecutive_empty_packets;

[hlundin-webrtc, 2016/05/12 12:23:39]

And here.

[aleloi, 2016/05/12 12:52:18]

Done.

[kwiberg-webrtc, 2016/05/12 13:01:51]

1. Please document these. (As a rule of thumb, it's much more useful to put
comments on data than on code.)

2. Why are these size_t?

 };
 
 }  // namespace acm2