Audio codec usage statistics

webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 18 matching lines @@
 class AudioCodingImpl;
 
 namespace acm2 {
 
 struct EncoderFactory;
 
 class AudioCodingModuleImpl final : public AudioCodingModule {
  public:
   friend webrtc::AudioCodingImpl;
 
+  static constexpr size_t kMaxAudioCodecNames = 64;

[ossu, 2016/05/12 12:50:14]

Maybe include something about logging in this name, since it's only for logging
purposes that this limit is applicable.

[kwiberg-webrtc, 2016/05/12 13:01:51]

In case some compiler (such as Visual Studio) complains that you need to put
this in the .cc file as well, try

  enum : size_t { kMaxAudioCodecNames = 64 };

instead.

[aleloi, 2016/05/12 13:25:47]

Added explaining comment and changed name to kMaxLoggedAudioCodecNames

+
   explicit AudioCodingModuleImpl(const AudioCodingModule::Config& config);
   ~AudioCodingModuleImpl() override;
 
   /////////////////////////////////////////
   //   Sender
   //
 
   // Can be called multiple times for Codec, CNG, RED.
   int RegisterSendCodec(const CodecInst& send_codec) override;
 
@@ skipping 239 matching lines @@
   bool first_10ms_data_ GUARDED_BY(acm_crit_sect_);
 
   bool first_frame_ GUARDED_BY(acm_crit_sect_);
   uint32_t last_timestamp_ GUARDED_BY(acm_crit_sect_);
   uint32_t last_rtp_timestamp_ GUARDED_BY(acm_crit_sect_);
 
   rtc::CriticalSection callback_crit_sect_;
   AudioPacketizationCallback* packetization_callback_
       GUARDED_BY(callback_crit_sect_);
   ACMVADCallback* vad_callback_ GUARDED_BY(callback_crit_sect_);
+
+  size_t codec_histogram_bins_log[kMaxAudioCodecNames];

[hlundin-webrtc, 2016/05/12 12:23:39]

Trailing underscore on member variables.

[aleloi, 2016/05/12 12:52:18]

Done.

+  size_t number_of_consecutive_empty_packets;

[hlundin-webrtc, 2016/05/12 12:23:39]

And here.

[aleloi, 2016/05/12 12:52:18]

Done.

[kwiberg-webrtc, 2016/05/12 13:01:51]

1. Please document these. (As a rule of thumb, it's much more useful to put
comments on data than on code.)

2. Why are these size_t?

 };
 
 }  // namespace acm2
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_AUDIO_CODING_ACM2_AUDIO_CODING_MODULE_IMPL_H_