VideoCapturerAndroid: Ignore erroneous startCaptureOnCameraThread calls instead of crashing

VideoCapturerAndroid: Ignore erroneous startCaptureOnCameraThread calls instead of crashing

Fix a bug where startCaptureOnCameraThread() is called while the camera is already successfully running. It may happen in the scenario when startCapture() is called, but startCaptureOnCameraThread() fails and posts a retry, then stopCapture() is called and removeCallbacksAndMessages() fails to remove the pending retry, and then startCapture() is called successfully.

BUG=b/28181364
R=glaznev@webrtc.org

Committed: https://crrev.com/210dd5c361e2e11a465e6de6e1f701c451c9bd65
Cr-Commit-Position: refs/heads/master@{#12697}

[magjed_webrtc, 2016-05-11 09:39:33]

Alex - please take a look.

[magjed_webrtc, 2016-05-11 13:05:19]

Description was changed from

==========
VideoCapturerAndroid: Ignore erroneous startCaptureOnCameraThread calls instead
of crashing

BUG=b/28181364
==========

to

==========
VideoCapturerAndroid: Ignore erroneous startCaptureOnCameraThread calls instead
of crashing

BUG=b/28181364
==========

[magjed_webrtc, 2016-05-11 13:05:19]

magjed@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[magjed_webrtc, 2016-05-11 13:05:26]

Alex - please take a look.

[AlexG, 2016-05-11 17:23:50]

lgtm

https://codereview.webrtc.org/1967053002/diff/1/webrtc/api/java/android/org/w...
File webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java (right):

https://codereview.webrtc.org/1967053002/diff/1/webrtc/api/java/android/org/w...
webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java:413: Logging.e(TAG,
"startCaptureOnCameraThread: Camera has already been started.");
Worth also to call onCameraError?

[magjed_webrtc, 2016-05-12 09:43:27]

Description was changed from

==========
VideoCapturerAndroid: Ignore erroneous startCaptureOnCameraThread calls instead
of crashing

BUG=b/28181364
==========

to

==========
VideoCapturerAndroid: Ignore erroneous startCaptureOnCameraThread calls instead
of crashing

Fix a bug where startCaptureOnCameraThread() is called while the camera is
already successfully running. It may happen in the scenario when startCapture()
is called, but startCaptureOnCameraThread() fails and posts a retry, then
stopCapture() is called and removeCallbacksAndMessages() fails to remove the
pending retry, and then startCapture() is called successfully.

BUG=b/28181364
==========

[magjed_webrtc, 2016-05-12 09:44:24]

https://codereview.webrtc.org/1967053002/diff/1/webrtc/api/java/android/org/w...
File webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java (right):

https://codereview.webrtc.org/1967053002/diff/1/webrtc/api/java/android/org/w...
webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java:413: Logging.e(TAG,
"startCaptureOnCameraThread: Camera has already been started.");
On 2016/05/11 17:23:50, AlexG wrote:
> Worth also to call onCameraError? 

I don't think so, because the camera should be running successfully at this
point.

[magjed_webrtc, 2016-05-12 09:44:31]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-05-12 09:44:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1967053002/1

[commit-bot: I haz the power, 2016-05-12 09:54:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 09:54:09]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/13233)

[commit-bot: I haz the power, 2016-05-12 10:40:40]

Description was changed from

==========
VideoCapturerAndroid: Ignore erroneous startCaptureOnCameraThread calls instead
of crashing

Fix a bug where startCaptureOnCameraThread() is called while the camera is
already successfully running. It may happen in the scenario when startCapture()
is called, but startCaptureOnCameraThread() fails and posts a retry, then
stopCapture() is called and removeCallbacksAndMessages() fails to remove the
pending retry, and then startCapture() is called successfully.

BUG=b/28181364
==========

to

==========
VideoCapturerAndroid: Ignore erroneous startCaptureOnCameraThread calls instead
of crashing

Fix a bug where startCaptureOnCameraThread() is called while the camera is
already successfully running. It may happen in the scenario when startCapture()
is called, but startCaptureOnCameraThread() fails and posts a retry, then
stopCapture() is called and removeCallbacksAndMessages() fails to remove the
pending retry, and then startCapture() is called successfully.

BUG=b/28181364
R=glaznev@webrtc.org

Committed: https://crrev.com/210dd5c361e2e11a465e6de6e1f701c451c9bd65
Cr-Commit-Position: refs/heads/master@{#12697}
==========

[magjed_webrtc, 2016-05-12 10:40:40]

Description was changed from

==========
VideoCapturerAndroid: Ignore erroneous startCaptureOnCameraThread calls instead
of crashing

Fix a bug where startCaptureOnCameraThread() is called while the camera is
already successfully running. It may happen in the scenario when startCapture()
is called, but startCaptureOnCameraThread() fails and posts a retry, then
stopCapture() is called and removeCallbacksAndMessages() fails to remove the
pending retry, and then startCapture() is called successfully.

BUG=b/28181364
R=glaznev@webrtc.org

Committed: https://crrev.com/210dd5c361e2e11a465e6de6e1f701c451c9bd65
Cr-Commit-Position: refs/heads/master@{#12697}
==========

to

==========
VideoCapturerAndroid: Ignore erroneous startCaptureOnCameraThread calls instead
of crashing

Fix a bug where startCaptureOnCameraThread() is called while the camera is
already successfully running. It may happen in the scenario when startCapture()
is called, but startCaptureOnCameraThread() fails and posts a retry, then
stopCapture() is called and removeCallbacksAndMessages() fails to remove the
pending retry, and then startCapture() is called successfully.

BUG=b/28181364
R=glaznev@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/210dd5c361e2e11a465e6de6e...
==========

[commit-bot: I haz the power, 2016-05-12 10:40:41]

Patchset 1 (id:??) landed as
https://crrev.com/210dd5c361e2e11a465e6de6e1f701c451c9bd65
Cr-Commit-Position: refs/heads/master@{#12697}

[magjed_webrtc, 2016-05-12 10:40:41]

Committed patchset #1 (id:1) manually as
210dd5c361e2e11a465e6de6e1f701c451c9bd65 (presubmit successful).