Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java

Issue 1967053002: VideoCapturerAndroid: Ignore erroneous startCaptureOnCameraThread calls instead of crashing (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java
diff --git a/webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java b/webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java
index 39ed12cfa3d2708c9b0ee74c3724a0d707154ad7..484cf66d4cc5e69b854c75a9e9b7e3b35ebfe1e6 100644
--- a/webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java
+++ b/webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java
@@ -410,7 +410,8 @@ public class VideoCapturerAndroid implements
Throwable error = null;
checkIsOnCameraThread();
if (camera != null) {
- throw new RuntimeException("Camera has already been started.");
+ Logging.e(TAG, "startCaptureOnCameraThread: Camera has already been started.");
AlexG 2016/05/11 17:23:50 Worth also to call onCameraError?
magjed_webrtc 2016/05/12 09:44:24 I don't think so, because the camera should be run
+ return;
}
this.applicationContext = applicationContext;
this.frameObserver = frameObserver;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698