Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1966423002: Remove webrtc/base/scoped_ptr.h (Closed)

Created:
4 years, 7 months ago by kwiberg-webrtc
Modified:
4 years, 7 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), fengyue_agora.io, zhuangzesen_agora.io, Andrew MacDonald, zhengzhonghou_agora.io, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, minyue-webrtc, mflodman, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove webrtc/base/scoped_ptr.h This is a re-land of https://codereview.webrtc.org/1942823002 TBR=tommi@webrtc.org BUG=webrtc:5520 Committed: https://crrev.com/fd8be3468a2edf4ff1d2b064fcc388464f2c10d1 Cr-Commit-Position: refs/heads/master@{#12750}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : remove new scoped_ptr uses #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -139 lines) Patch
M talk/LICENSE_THIRD_PARTY View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/api/audiotrack.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/jsepsessiondescription.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/localaudiosource.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/mediastreamprovider.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/peerconnection.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/peerconnectionfactory.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 1 2 chunks +9 lines, -9 lines 0 comments Download
M webrtc/api/rtpsender.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/statstypes.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/test/fakeaudiocapturemodule.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/videocapturertracksource.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/audio_send_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/base.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/messagehandler.h View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/base/scoped_ptr.h View 1 chunk +0 lines, -49 lines 0 comments Download
M webrtc/call/rtc_event_log_parser.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_audio/real_fourier.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_video/bitrate_adjuster.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/examples/peerconnection/client/conductor.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/examples/peerconnection/client/peer_connection_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/libjingle/xmllite/xmlbuilder.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/libjingle/xmllite/xmlelement.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/libjingle/xmllite/xmlnsstack.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/fakexmppclient.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/libjingle/xmpp/hangoutpubsubclient.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/pubsubstateclient.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/xmpplogintask.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/xmpplogintask_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_device/dummy/file_audio_device_factory.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/cropping_window_capturer.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/desktop_and_cursor_composer.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/desktop_capturer.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/shared_memory.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/include/remote_ntp_time_estimator.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_utility.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/utility/include/jvm_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/utility/include/process_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/packet_buffer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/rtp_frame_reference_finder.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/test/rtp_player.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/util/noise_estimation.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/asyncstuntcpsocket.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/fakeportallocator.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/stunserver.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/tcpport_unittest.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M webrtc/p2p/base/testrelayserver.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/transportdescription.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/client/basicportallocator.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/quic/quictransportchannel.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/stunprober/stunprober.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/pc/mediasession_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCIceCandidate+Private.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints+Private.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCMediaStreamTrack+Private.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/system_wrappers/include/clock.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/system_wrappers/include/data_log_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/system_wrappers/include/utf_util_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/system_wrappers/source/file_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/system_wrappers/source/trace_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/configurable_frame_size_encoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/direct_transport.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/fake_audio_device.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/fake_network_pipe.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/frame_generator_capturer.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/test_suite.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966423002/40001
4 years, 7 months ago (2016-05-15 02:09:45 UTC) #3
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-15 02:44:18 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-15 02:44:25 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fd8be3468a2edf4ff1d2b064fcc388464f2c10d1
Cr-Commit-Position: refs/heads/master@{#12750}

Powered by Google App Engine
This is Rietveld 408576698