Android: Add support for cropping textures

Android: Add support for cropping textures

BUG=b/28622232
R=glaznev@webrtc.org, nisse@webrtc.org

Committed: https://crrev.com/a3002db8d63aecd2a3ccf630afef9a868e7e1f78
Cr-Commit-Position: refs/heads/master@{#12720}

[magjed_webrtc, 2016-05-11 17:17:37]

magjed@webrtc.org changed reviewers:
+ glaznev@webrtc.org, nisse@webrtc.org

[magjed_webrtc, 2016-05-11 17:17:48]

Please take a look.

[magjed_webrtc, 2016-05-11 17:18:25]

Description was changed from

==========
Android: Add support for cropping textures
==========

to

==========
Android: Add support for cropping textures

BUG=b/28622232
==========

[nisse-webrtc, 2016-05-12 10:32:51]

LGTM

https://codereview.webrtc.org/1965953003/diff/1/webrtc/api/java/jni/native_ha...
File webrtc/api/java/jni/native_handle_impl.cc (right):

https://codereview.webrtc.org/1965953003/diff/1/webrtc/api/java/jni/native_ha...
webrtc/api/java/jni/native_handle_impl.cc:90: memcpy(a, mul_result,
sizeof(mul_result));
It would be prettier if MultiplyMatrix allowed in-place operation. But overkill
to design great matrix handling code just for this.

Is there no useful matrix things in the c++ std library? Something like
template<type element_t, size_t columns, size_t rows, ptrdiff_t row_stride,
ptrdiff_t column_stride>?

[magjed_webrtc, 2016-05-12 10:49:51]

https://codereview.webrtc.org/1965953003/diff/1/webrtc/api/java/jni/native_ha...
File webrtc/api/java/jni/native_handle_impl.cc (right):

https://codereview.webrtc.org/1965953003/diff/1/webrtc/api/java/jni/native_ha...
webrtc/api/java/jni/native_handle_impl.cc:90: memcpy(a, mul_result,
sizeof(mul_result));
On 2016/05/12 10:32:51, nisse-webrtc wrote:
> It would be prettier if MultiplyMatrix allowed in-place operation. But
overkill
> to design great matrix handling code just for this.
> 
> Is there no useful matrix things in the c++ std library? Something like
> template<type element_t, size_t columns, size_t rows, ptrdiff_t row_stride,
> ptrdiff_t column_stride>?

There is no matrix support in std, but there exists a lot of external libraries
like Eigen. We could reduce the 4x4 matrices to 2x3 instead if we are concerned
about overhead.

[AlexG, 2016-05-12 23:12:44]

lgtm

https://codereview.webrtc.org/1965953003/diff/1/webrtc/api/java/jni/native_ha...
File webrtc/api/java/jni/native_handle_impl.cc (right):

https://codereview.webrtc.org/1965953003/diff/1/webrtc/api/java/jni/native_ha...
webrtc/api/java/jni/native_handle_impl.cc:200:
CropMatrix(buffer->native_handle_.sampling_matrix,
Call this only if (cropped_width != dst_width || cropped_height != dst_height) ?

[magjed_webrtc, 2016-05-13 07:59:47]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2016-05-13 07:59:48]

The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org,
nisse@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1965953003/#ps20001 (title:
"Only call CropMatrix when necessary.")

[commit-bot: I haz the power, 2016-05-13 07:59:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965953003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965953003/20001

[magjed_webrtc, 2016-05-13 07:59:58]

https://codereview.webrtc.org/1965953003/diff/1/webrtc/api/java/jni/native_ha...
File webrtc/api/java/jni/native_handle_impl.cc (right):

https://codereview.webrtc.org/1965953003/diff/1/webrtc/api/java/jni/native_ha...
webrtc/api/java/jni/native_handle_impl.cc:200:
CropMatrix(buffer->native_handle_.sampling_matrix,
On 2016/05/12 23:12:44, AlexG wrote:
> Call this only if (cropped_width != dst_width || cropped_height != dst_height)
?

Done.

[commit-bot: I haz the power, 2016-05-13 08:13:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 08:13:17]

Try jobs failed on following builders:
  linux_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/15069)

[magjed_webrtc, 2016-05-13 10:51:18]

Description was changed from

==========
Android: Add support for cropping textures

BUG=b/28622232
==========

to

==========
Android: Add support for cropping textures

BUG=b/28622232
R=glaznev@webrtc.org, nisse@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/a3002db8d63aecd2a3ccf630a...
==========

[commit-bot: I haz the power, 2016-05-13 10:51:18]

Description was changed from

==========
Android: Add support for cropping textures

BUG=b/28622232
R=glaznev@webrtc.org, nisse@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/a3002db8d63aecd2a3ccf630a...
==========

to

==========
Android: Add support for cropping textures

BUG=b/28622232
R=glaznev@webrtc.org, nisse@webrtc.org

Committed: https://crrev.com/a3002db8d63aecd2a3ccf630afef9a868e7e1f78
Cr-Commit-Position: refs/heads/master@{#12720}
==========

[commit-bot: I haz the power, 2016-05-13 10:51:19]

Patchset 2 (id:??) landed as
https://crrev.com/a3002db8d63aecd2a3ccf630afef9a868e7e1f78
Cr-Commit-Position: refs/heads/master@{#12720}

[magjed_webrtc, 2016-05-13 10:51:19]

Committed patchset #2 (id:20001) manually as
a3002db8d63aecd2a3ccf630afef9a868e7e1f78 (presubmit successful).