webrtc/api/java/jni/native_handle_impl.h - Issue 1965953003: Android: Add support for cropping textures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/java/jni/native_handle_impl.h

Issue 1965953003: Android: Add support for cropping textures (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Only call CropMatrix when necessary. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/java/jni/native_handle_impl.h

diff --git a/webrtc/api/java/jni/native_handle_impl.h b/webrtc/api/java/jni/native_handle_impl.h

index 859c3713b465bf1e5ffd3508132e2656a8e2b709..b781815718dfd89f2d175060b3ef69a4b4e88e7e 100644

--- a/webrtc/api/java/jni/native_handle_impl.h

+++ b/webrtc/api/java/jni/native_handle_impl.h

@@ -38,8 +38,11 @@ class AndroidTextureBuffer : public webrtc::NativeHandleBuffer {

~AndroidTextureBuffer();

rtc::scoped_refptr<VideoFrameBuffer> NativeToI420Buffer() override;

- rtc::scoped_refptr<AndroidTextureBuffer> ScaleAndRotate(

- int dst_widht,

+ // First crop, then scale to dst resolution, and then rotate.

+ rtc::scoped_refptr<AndroidTextureBuffer> CropScaleAndRotate(

+ int cropped_width,

+ int cropped_height,

+ int dst_width,

int dst_height,

webrtc::VideoRotation rotation);