Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1958053002: Revert "Reland of Remove SendPacer from ViEEncoder (Closed)

Created:
4 years, 7 months ago by perkj_webrtc
Modified:
4 years, 7 months ago
Reviewers:
ivoc, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Reland of Remove SendPacer from ViEEncoder Revert due to crbug/609816. Investigation is ongoing. This reverts commit 28a44564c93b12839618dc0da2e2541ec6a0db23. (https://codereview.webrtc.org/1947873002/) TBR=stefan@webrtc.org, ivoc@webrtc.org, BUG=609816, webrtc:5687 Committed: https://crrev.com/e30c27205148b34ba421184efe65f6a0780b436d Cr-Commit-Position: refs/heads/master@{#12663}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -570 lines) Patch
M webrtc/audio/audio_receive_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/call/bitrate_allocator.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/call/bitrate_allocator.cc View 3 chunks +13 lines, -11 lines 0 comments Download
M webrtc/call/bitrate_allocator_unittest.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M webrtc/call/call.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.h View 3 chunks +7 lines, -10 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.cc View 3 chunks +5 lines, -13 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/bitrate_controller.h View 4 chunks +1 line, -13 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/mock/mock_bitrate_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 5 chunks +17 lines, -94 lines 0 comments Download
D webrtc/modules/congestion_controller/congestion_controller_unittest.cc View 1 chunk +0 lines, -111 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 5 chunks +6 lines, -38 lines 0 comments Download
M webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h View 1 chunk +4 lines, -10 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/pacing/mock/mock_paced_sender.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.h View 6 chunks +17 lines, -21 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 7 chunks +27 lines, -36 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 23 chunks +205 lines, -159 lines 0 comments Download
M webrtc/modules/pacing/packet_router.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M webrtc/video/encoder_state_feedback_unittest.cc View 4 chunks +15 lines, -3 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M webrtc/video/vie_encoder.h View 2 chunks +6 lines, -1 line 0 comments Download
M webrtc/video/vie_encoder.cc View 5 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
perkj_webrtc
4 years, 7 months ago (2016-05-09 08:44:42 UTC) #2
perkj_webrtc
4 years, 7 months ago (2016-05-09 08:45:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958053002/1
4 years, 7 months ago (2016-05-09 08:45:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/builds/12855) android_compile_x64_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 7 months ago (2016-05-09 08:46:49 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958053002/20001
4 years, 7 months ago (2016-05-09 10:07:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958053002/20001
4 years, 7 months ago (2016-05-09 11:55:35 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 11:57:15 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 11:57:25 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e30c27205148b34ba421184efe65f6a0780b436d
Cr-Commit-Position: refs/heads/master@{#12663}

Powered by Google App Engine
This is Rietveld 408576698