Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1955273002:
Fix codec name logging in ivf_file_writer.cc (Closed)
|
Created:
4 years, 7 months ago by hta-webrtc Modified:
4 years, 7 months ago Reviewers:
pbos-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix codec name logging in ivf_file_writer.cc
The logging code was using the wrong constants for the
codec type, resulting in the type always being "unknown".
Tested: modules_unittests --gtest_filter='IvfFile*' -logs
BUG=
Committed: https://crrev.com/db3eea0ede9dedd01cdee0d13611410a0c4edf7d
Cr-Commit-Position: refs/heads/master@{#12668}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 15 (7 generated)
Description was changed from ========== Fix codec name logging in ivf_file_writer.cc The logging code was using the wrong constants for the codec type, resulting in the type always being "unknown". Tested: modules_unittests --gtest_filter='IvfFile*' -logs BUG= ========== to ========== Fix codec name logging in ivf_file_writer.cc The logging code was using the wrong constants for the codec type, resulting in the type always being "unknown". Tested: modules_unittests --gtest_filter='IvfFile*' -logs BUG= ==========
hta@webrtc.org changed reviewers: + pbos@webrtc.org
The CQ bit was checked by hta@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955273002/1
Drive-by bug fix.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_msan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/9903)
lgtm w/ nit https://codereview.webrtc.org/1955273002/diff/1/webrtc/modules/video_coding/u... File webrtc/modules/video_coding/utility/ivf_file_writer.cc (right): https://codereview.webrtc.org/1955273002/diff/1/webrtc/modules/video_coding/u... webrtc/modules/video_coding/utility/ivf_file_writer.cc:120: switch (codec_type_) { Can you store codec_type_ as the proper enum type so that this gets caught in compile-time?
Thanks - this is one of the things C++ does not catch. https://codereview.webrtc.org/1955273002/diff/1/webrtc/modules/video_coding/u... File webrtc/modules/video_coding/utility/ivf_file_writer.cc (right): https://codereview.webrtc.org/1955273002/diff/1/webrtc/modules/video_coding/u... webrtc/modules/video_coding/utility/ivf_file_writer.cc:120: switch (codec_type_) { On 2016/05/09 16:44:33, pbos-webrtc wrote: > Can you store codec_type_ as the proper enum type so that this gets caught in > compile-time? It was, and it didn't. codec_type_ is the proper enum type, and the compiler did not catch the use of enum values from another enum.
The CQ bit was checked by hta@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955273002/1
Message was sent while issue was closed.
Description was changed from ========== Fix codec name logging in ivf_file_writer.cc The logging code was using the wrong constants for the codec type, resulting in the type always being "unknown". Tested: modules_unittests --gtest_filter='IvfFile*' -logs BUG= ========== to ========== Fix codec name logging in ivf_file_writer.cc The logging code was using the wrong constants for the codec type, resulting in the type always being "unknown". Tested: modules_unittests --gtest_filter='IvfFile*' -logs BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix codec name logging in ivf_file_writer.cc The logging code was using the wrong constants for the codec type, resulting in the type always being "unknown". Tested: modules_unittests --gtest_filter='IvfFile*' -logs BUG= ========== to ========== Fix codec name logging in ivf_file_writer.cc The logging code was using the wrong constants for the codec type, resulting in the type always being "unknown". Tested: modules_unittests --gtest_filter='IvfFile*' -logs BUG= Committed: https://crrev.com/db3eea0ede9dedd01cdee0d13611410a0c4edf7d Cr-Commit-Position: refs/heads/master@{#12668} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/db3eea0ede9dedd01cdee0d13611410a0c4edf7d Cr-Commit-Position: refs/heads/master@{#12668} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
