Fix codec name logging in ivf_file_writer.cc

webrtc/modules/video_coding/utility/ivf_file_writer.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 99 matching lines @@
   width_ = encoded_image._encodedWidth;
   height_ = encoded_image._encodedHeight;
   RTC_CHECK_GT(width_, 0);
   RTC_CHECK_GT(height_, 0);
   using_capture_timestamps_ = encoded_image._timeStamp == 0;
 
   if (!WriteHeader())
     return false;
 
   std::string codec_name;
   switch (codec_type_) {

[pbos-webrtc, 2016/05/09 16:44:33]

Can you store codec_type_ as the proper enum type so that this gets caught in
compile-time?

[hta-webrtc, 2016/05/09 16:59:08]

It was, and it didn't. codec_type_ is the proper enum type, and the compiler did
not catch the use of enum values from another enum.

-    case kRtpVideoVp8:
+    case kVideoCodecVP8:
       codec_name = "VP8";
       break;
-    case kRtpVideoVp9:
+    case kVideoCodecVP9:
       codec_name = "VP9";
       break;
-    case kRtpVideoH264:
+    case kVideoCodecH264:
       codec_name = "H264";
       break;
     default:
-      codec_name = "Unkown";
+      codec_name = "Unknown";
   }
   LOG(LS_WARNING) << "Created IVF file " << file_name_
                   << " for codec data of type " << codec_name
                   << " at resolution " << width_ << " x " << height_
                   << ", using " << (using_capture_timestamps_ ? "1" : "90")
                   << "kHz clock resolution.";
   return true;
 }
 
 bool IvfFileWriter::WriteFrame(const EncodedImage& encoded_image) {
@@ skipping 45 matching lines @@
     if (remove(file_name_.c_str()) != 0)
       LOG(LS_WARNING) << "Failed to remove empty IVF file " << file_name_;
 
     return true;
   }
 
   return WriteHeader() && (file_->CloseFile() == 0);
 }
 
 }  // namespace webrtc