Introduced the new APM data logging functionality into the AEC echo_cancellation.* API layer.

Introduced the new APM data logging functionality into the AEC echo_cancellation.* API layer.

BUG=webrtc:5298
Committed: https://crrev.com/3f08dc656dc22edf658a8393b5b03a46b23aa4e8
Cr-Commit-Position: refs/heads/master@{#12635}

[peah-webrtc, 2016-05-04 07:06:56]

Description was changed from

==========
Introduced the new APM data logging functionality into the AEC
echo_cancellatio.* API layer.

BUG=
==========

to

==========
Introduced the new APM data logging functionality into the AEC
echo_cancellatio.* API layer.

BUG=webrtc:5298
==========

[peah-webrtc, 2016-05-04 07:07:08]

peah@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-05-04 07:20:35]

lgtm with one comment.

https://codereview.webrtc.org/1952593002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec/echo_cancellation.cc (right):

https://codereview.webrtc.org/1952593002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/echo_cancellation.cc:357:
aecpc->data_dumper->DumpRaw("aec_buf", 1, &far_buf_size_samples);
I don't know if the logged variable names are up for review in this CL, but I
think aec_buf seems a bit too generic for dumping far_buf_size_samples. Could
you be a bit more specific?

[peah-webrtc, 2016-05-04 11:38:05]

https://codereview.webrtc.org/1952593002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec/echo_cancellation.cc (right):

https://codereview.webrtc.org/1952593002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/echo_cancellation.cc:357:
aecpc->data_dumper->DumpRaw("aec_buf", 1, &far_buf_size_samples);
On 2016/05/04 07:20:35, hlundin-webrtc wrote:
> I don't know if the logged variable names are up for review in this CL, but I
> think aec_buf seems a bit too generic for dumping far_buf_size_samples. Could
> you be a bit more specific?

Absolutely! I for now kept the name that was there before. I changed name to
system_delay, as that is what is actually logged.
I also changed the aec_delay file name to aec_known_delay to distinguish it from
the former.

Probably we should revisit these decisions in the future.

[peah-webrtc, 2016-05-04 11:38:25]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-05-04 11:38:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1952593002/#ps40001 (title:
"Rebase")

[commit-bot: I haz the power, 2016-05-04 11:38:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952593002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952593002/40001

[commit-bot: I haz the power, 2016-05-04 11:55:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 11:55:19]

Try jobs failed on following builders:
  mac_baremetal on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/11094)

[peah-webrtc, 2016-05-04 19:12:14]

Patchset #4 (id:60001) has been deleted

[peah-webrtc, 2016-05-04 19:12:25]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-05-04 19:12:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1952593002/#ps100001 (title:
"Rebase")

[commit-bot: I haz the power, 2016-05-04 19:12:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952593002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952593002/100001

[commit-bot: I haz the power, 2016-05-04 21:13:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 21:13:02]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[peah-webrtc, 2016-05-05 09:57:58]

Description was changed from

==========
Introduced the new APM data logging functionality into the AEC
echo_cancellatio.* API layer.

BUG=webrtc:5298
==========

to

==========
Introduced the new APM data logging functionality into the AEC
echo_cancellation.* API layer.

BUG=webrtc:5298
==========

[peah-webrtc, 2016-05-05 09:58:09]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-05-05 09:58:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952593002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952593002/100001

[commit-bot: I haz the power, 2016-05-05 10:04:00]

Description was changed from

==========
Introduced the new APM data logging functionality into the AEC
echo_cancellation.* API layer.

BUG=webrtc:5298
==========

to

==========
Introduced the new APM data logging functionality into the AEC
echo_cancellation.* API layer.

BUG=webrtc:5298
==========

[commit-bot: I haz the power, 2016-05-05 10:04:01]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-05-05 10:04:13]

Description was changed from

==========
Introduced the new APM data logging functionality into the AEC
echo_cancellation.* API layer.

BUG=webrtc:5298
==========

to

==========
Introduced the new APM data logging functionality into the AEC
echo_cancellation.* API layer.

BUG=webrtc:5298

Committed: https://crrev.com/3f08dc656dc22edf658a8393b5b03a46b23aa4e8
Cr-Commit-Position: refs/heads/master@{#12635}
==========

[commit-bot: I haz the power, 2016-05-05 10:04:14]

Patchset 5 (id:??) landed as
https://crrev.com/3f08dc656dc22edf658a8393b5b03a46b23aa4e8
Cr-Commit-Position: refs/heads/master@{#12635}