webrtc/modules/audio_processing/aec/echo_cancellation_internal.h - Issue 1952593002: Introduced the new APM data logging functionality into the AEC echo_cancellation.* API layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/aec/echo_cancellation_internal.h

Issue 1952593002: Introduced the new APM data logging functionality into the AEC echo_cancellation.* API layer. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/aec/echo_cancellation.cc ('k') | webrtc/modules/audio_processing/logging/apm_data_dumper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/aec/echo_cancellation_internal.h

diff --git a/webrtc/modules/audio_processing/aec/echo_cancellation_internal.h b/webrtc/modules/audio_processing/aec/echo_cancellation_internal.h

index 188fb576f0b9f7bb15eb1808e6212b9aa9082c3b..5e79626d6f0d746522026537db5283f85df54283 100644

--- a/webrtc/modules/audio_processing/aec/echo_cancellation_internal.h

+++ b/webrtc/modules/audio_processing/aec/echo_cancellation_internal.h

@@ -11,6 +11,8 @@

#ifndef WEBRTC_MODULES_AUDIO_PROCESSING_AEC_ECHO_CANCELLATION_INTERNAL_H_

#define WEBRTC_MODULES_AUDIO_PROCESSING_AEC_ECHO_CANCELLATION_INTERNAL_H_

+#include <memory>

extern "C" {

#include "webrtc/common_audio/ring_buffer.h"

}

@@ -18,7 +20,11 @@ extern "C" {

namespace webrtc {

+class ApmDataDumper;

typedef struct Aec {

+ std::unique_ptr<ApmDataDumper> data_dumper;

int delayCtr;

int sampFreq;

int splitSampFreq;

@@ -45,12 +51,6 @@ typedef struct Aec {

int checkBuffSize;

short lastDelayDiff;

-#if WEBRTC_AEC_DEBUG_DUMP

- FILE* bufFile;

- FILE* delayFile;

- FILE* skewFile;

-#endif

// Structures

void* resampler;