Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1950963003: Enable NACK for audio even if there are no send streams. (Closed)

Created:
4 years, 7 months ago by Taylor Brandstetter
Modified:
4 years, 7 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable NACK for audio even if there are no send streams. BUG=webrtc:5762 Committed: https://crrev.com/b56069e650210ac7b11b5e5507ac517270f1a793 Cr-Commit-Position: refs/heads/master@{#12641}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M webrtc/media/engine/webrtcvoiceengine.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Taylor Brandstetter
4 years, 7 months ago (2016-05-04 21:00:16 UTC) #2
the sun
LGTM; short and sweet, thank you!
4 years, 7 months ago (2016-05-06 09:26:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950963003/1
4 years, 7 months ago (2016-05-06 10:18:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 11:57:08 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 11:57:18 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b56069e650210ac7b11b5e5507ac517270f1a793
Cr-Commit-Position: refs/heads/master@{#12641}

Powered by Google App Engine
This is Rietveld 408576698