webrtc/media/engine/webrtcvoiceengine_unittest.cc - Issue 1950963003: Enable NACK for audio even if there are no send streams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvoiceengine_unittest.cc

Issue 1950963003: Enable NACK for audio even if there are no send streams. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/media/engine/webrtcvoiceengine_unittest.cc

diff --git a/webrtc/media/engine/webrtcvoiceengine_unittest.cc b/webrtc/media/engine/webrtcvoiceengine_unittest.cc

index c72775a98504fc7102a9fd920ab47c87faa0d346..5fc75c73afad6c76d95aa73e4f503a075951a4ac 100644

--- a/webrtc/media/engine/webrtcvoiceengine_unittest.cc

+++ b/webrtc/media/engine/webrtcvoiceengine_unittest.cc

@@ -1302,7 +1302,8 @@ TEST_F(WebRtcVoiceEngineTestFake, SetSendCodecEnableNackAsCallee) {

cricket::kParamValueEmpty));

EXPECT_FALSE(voe_.GetNACK(channel_num));

EXPECT_TRUE(channel_->SetSendParameters(parameters));

- EXPECT_FALSE(voe_.GetNACK(channel_num));

+ // NACK should be enabled even with no send stream.

+ EXPECT_TRUE(voe_.GetNACK(channel_num));

EXPECT_TRUE(channel_->AddSendStream(

cricket::StreamParams::CreateLegacy(kSsrc1)));

« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.cc ('k') | no next file » | no next file with comments »