Reland of Remove SendPacer from ViEEncoder (patchset #13 id:240001 of https://codereview.we…

Revert "Revert of Remove SendPacer from ViEEncoder (patchset #13 id:240001 of https://codereview.webrtc.org/1917793002/ )"

This reverts commit 825eb58d59940a4c3c9837595c4b3b07059c93ca.

This Relands the cl reviewed in https://codereview.webrtc.org/1917793002/

patchset #1 is a pure reland.
patchset #2 fix an overflow in BitrateProber that caused WebRtcVideoChannel2BaseTest.TwoStreamsSendAndReceive to fail.

Original cl description:
Remove SendPacer from ViEEncoder
This CL moves the logic where the ViEEncoder pause if the pacer is full to the BitrateController. If the queue is full, the controller reports a bitrate of zero to  Call (and BitrateAllocator)

R=stefan@webrtc.org
TBR=mflodman@webrtc.org

BUG=webrtc:5687
Committed: https://crrev.com/28a44564c93b12839618dc0da2e2541ec6a0db23
Cr-Commit-Position: refs/heads/master@{#12630}

[perkj_webrtc, 2016-05-04 12:05:41]

Description was changed from

==========
Revert "Revert of Remove SendPacer from ViEEncoder (patchset #13 id:240001 of
https://codereview.webrtc.org/1917793002/ )"

This reverts commit 825eb58d59940a4c3c9837595c4b3b07059c93ca.

BUG=
==========

to

==========
Revert "Revert of Remove SendPacer from ViEEncoder (patchset #13 id:240001 of
https://codereview.webrtc.org/1917793002/ )"

This reverts commit 825eb58d59940a4c3c9837595c4b3b07059c93ca.

This Relands the cl reviewed in https://codereview.webrtc.org/1917793002/

patchset #1 is a pure reland.
patchset #2 fix an overflow in BitrateProber that caused
WebRtcVideoChannel2BaseTest.TwoStreamsSendAndReceive to fail.

Original cl description:
Remove SendPacer from ViEEncoder
This CL moves the logic where the ViEEncoder pause if the pacer is full to the
BitrateController. If the queue is full, the controller reports a bitrate of
zero to  Call (and BitrateAllocator)

BUG=webrtc:5687
==========

[perkj_webrtc, 2016-05-04 12:05:41]

perkj@webrtc.org changed reviewers:
+ stefan@webrtc.org

[perkj_webrtc, 2016-05-04 12:07:38]

The CQ bit was checked by perkj@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 12:07:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947873002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947873002/20001

[perkj_webrtc, 2016-05-04 12:07:49]

Please?

[stefan-webrtc, 2016-05-04 12:29:17]

lgtm

[stefan-webrtc, 2016-05-04 12:29:34]

The CQ bit was unchecked by stefan@webrtc.org

[stefan-webrtc, 2016-05-04 12:29:34]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2016-05-04 12:29:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947873002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947873002/20001

[commit-bot: I haz the power, 2016-05-04 12:32:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 12:32:44]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5298)

[perkj_webrtc, 2016-05-04 14:34:48]

Description was changed from

==========
Revert "Revert of Remove SendPacer from ViEEncoder (patchset #13 id:240001 of
https://codereview.webrtc.org/1917793002/ )"

This reverts commit 825eb58d59940a4c3c9837595c4b3b07059c93ca.

This Relands the cl reviewed in https://codereview.webrtc.org/1917793002/

patchset #1 is a pure reland.
patchset #2 fix an overflow in BitrateProber that caused
WebRtcVideoChannel2BaseTest.TwoStreamsSendAndReceive to fail.

Original cl description:
Remove SendPacer from ViEEncoder
This CL moves the logic where the ViEEncoder pause if the pacer is full to the
BitrateController. If the queue is full, the controller reports a bitrate of
zero to  Call (and BitrateAllocator)

BUG=webrtc:5687
==========

to

==========
Revert "Revert of Remove SendPacer from ViEEncoder (patchset #13 id:240001 of
https://codereview.webrtc.org/1917793002/ )"

This reverts commit 825eb58d59940a4c3c9837595c4b3b07059c93ca.

This Relands the cl reviewed in https://codereview.webrtc.org/1917793002/

patchset #1 is a pure reland.
patchset #2 fix an overflow in BitrateProber that caused
WebRtcVideoChannel2BaseTest.TwoStreamsSendAndReceive to fail.

Original cl description:
Remove SendPacer from ViEEncoder
This CL moves the logic where the ViEEncoder pause if the pacer is full to the
BitrateController. If the queue is full, the controller reports a bitrate of
zero to  Call (and BitrateAllocator)

TBR=mflodman@webrtc.org

BUG=webrtc:5687
==========

[perkj_webrtc, 2016-05-04 14:35:44]

perkj@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[perkj_webrtc, 2016-05-04 14:35:58]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2016-05-04 14:35:59]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1947873002/#ps40001 (title:
"Fixed CongestionController backwards compatibility")

[commit-bot: I haz the power, 2016-05-04 14:36:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947873002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947873002/40001

[perkj_webrtc, 2016-05-04 15:13:10]

Description was changed from

==========
Revert "Revert of Remove SendPacer from ViEEncoder (patchset #13 id:240001 of
https://codereview.webrtc.org/1917793002/ )"

This reverts commit 825eb58d59940a4c3c9837595c4b3b07059c93ca.

This Relands the cl reviewed in https://codereview.webrtc.org/1917793002/

patchset #1 is a pure reland.
patchset #2 fix an overflow in BitrateProber that caused
WebRtcVideoChannel2BaseTest.TwoStreamsSendAndReceive to fail.

Original cl description:
Remove SendPacer from ViEEncoder
This CL moves the logic where the ViEEncoder pause if the pacer is full to the
BitrateController. If the queue is full, the controller reports a bitrate of
zero to  Call (and BitrateAllocator)

TBR=mflodman@webrtc.org

BUG=webrtc:5687
==========

to

==========
Revert "Revert of Remove SendPacer from ViEEncoder (patchset #13 id:240001 of
https://codereview.webrtc.org/1917793002/ )"

This reverts commit 825eb58d59940a4c3c9837595c4b3b07059c93ca.

This Relands the cl reviewed in https://codereview.webrtc.org/1917793002/

patchset #1 is a pure reland.
patchset #2 fix an overflow in BitrateProber that caused
WebRtcVideoChannel2BaseTest.TwoStreamsSendAndReceive to fail.

Original cl description:
Remove SendPacer from ViEEncoder
This CL moves the logic where the ViEEncoder pause if the pacer is full to the
BitrateController. If the queue is full, the controller reports a bitrate of
zero to  Call (and BitrateAllocator)

R=stefan@webrtc.org
TBR=mflodman@webrtc.org

BUG=webrtc:5687

Committed:
https://chromium.googlesource.com/external/webrtc/+/28a44564c93b12839618dc0da...
==========

[perkj_webrtc, 2016-05-04 15:13:12]

Committed patchset #3 (id:40001) manually as
28a44564c93b12839618dc0da2e2541ec6a0db23 (presubmit successful).

[commit-bot: I haz the power, 2016-05-04 15:13:15]

Description was changed from

==========
Revert "Revert of Remove SendPacer from ViEEncoder (patchset #13 id:240001 of
https://codereview.webrtc.org/1917793002/ )"

This reverts commit 825eb58d59940a4c3c9837595c4b3b07059c93ca.

This Relands the cl reviewed in https://codereview.webrtc.org/1917793002/

patchset #1 is a pure reland.
patchset #2 fix an overflow in BitrateProber that caused
WebRtcVideoChannel2BaseTest.TwoStreamsSendAndReceive to fail.

Original cl description:
Remove SendPacer from ViEEncoder
This CL moves the logic where the ViEEncoder pause if the pacer is full to the
BitrateController. If the queue is full, the controller reports a bitrate of
zero to  Call (and BitrateAllocator)

R=stefan@webrtc.org
TBR=mflodman@webrtc.org

BUG=webrtc:5687

Committed:
https://chromium.googlesource.com/external/webrtc/+/28a44564c93b12839618dc0da...
==========

to

==========
Revert "Revert of Remove SendPacer from ViEEncoder (patchset #13 id:240001 of
https://codereview.webrtc.org/1917793002/ )"

This reverts commit 825eb58d59940a4c3c9837595c4b3b07059c93ca.

This Relands the cl reviewed in https://codereview.webrtc.org/1917793002/

patchset #1 is a pure reland.
patchset #2 fix an overflow in BitrateProber that caused
WebRtcVideoChannel2BaseTest.TwoStreamsSendAndReceive to fail.

Original cl description:
Remove SendPacer from ViEEncoder
This CL moves the logic where the ViEEncoder pause if the pacer is full to the
BitrateController. If the queue is full, the controller reports a bitrate of
zero to  Call (and BitrateAllocator)

R=stefan@webrtc.org
TBR=mflodman@webrtc.org

BUG=webrtc:5687

Committed: https://crrev.com/28a44564c93b12839618dc0da2e2541ec6a0db23
Cr-Commit-Position: refs/heads/master@{#12630}
==========