Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/p2p/base/tcpport.cc

Issue 1940493002: Add Stats to Stun ping. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Store ConnectionInfo to Connection to reduce duplication. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/p2p/base/port.h ('K') | « webrtc/p2p/base/port_unittest.cc ('k') | webrtc/p2p/base/transport.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/tcpport.cc
diff --git a/webrtc/p2p/base/tcpport.cc b/webrtc/p2p/base/tcpport.cc
index 5ccb8108a058b0ab608c7c8b454f10b2882016d9..2acdf9bc670952d46e243b3a1294856185359f21 100644
--- a/webrtc/p2p/base/tcpport.cc
+++ b/webrtc/p2p/base/tcpport.cc
@@ -351,10 +351,12 @@ int TCPConnection::Send(const void* data, size_t size,
error_ = EWOULDBLOCK;
return SOCKET_ERROR;
}
- sent_packets_total_++;
+ // sent_packets_total_++;
pthatcher1 2016/06/01 21:39:49 This comment isn't needed.
zhihuang1 2016/06/01 22:34:04 Done.
+ connection_info_.sent_total_packets++;
int sent = socket_->Send(data, size, options);
if (sent < 0) {
- sent_packets_discarded_++;
+ // sent_packets_discarded_++;
pthatcher1 2016/06/01 21:39:49 Nor this one.
zhihuang1 2016/06/01 22:34:04 Done.
+ connection_info_.sent_discarded_packets++;
error_ = socket_->GetError();
} else {
send_rate_tracker_.AddSamples(sent);
« webrtc/p2p/base/port.h ('K') | « webrtc/p2p/base/port_unittest.cc ('k') | webrtc/p2p/base/transport.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698