Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: webrtc/p2p/base/port.h

Issue 1940493002: Add Stats to Stun ping. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Store ConnectionInfo to Connection to reduce duplication. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/port.h
diff --git a/webrtc/p2p/base/port.h b/webrtc/p2p/base/port.h
index 704fbb7a65416d42fab37cd8858a43fcdcc0292d..b2fe340732aac06f616ef45fcf99b8102df0fc2f 100644
--- a/webrtc/p2p/base/port.h
+++ b/webrtc/p2p/base/port.h
@@ -462,14 +462,8 @@ class Connection : public CandidatePairInterface,
// Estimate of the round-trip time over this connection.
int rtt() const { return rtt_; }
- size_t sent_total_bytes();
- size_t sent_bytes_second();
- // Used to track how many packets are discarded in the application socket due
- // to errors.
- size_t sent_discarded_packets();
- size_t sent_total_packets();
- size_t recv_total_bytes();
- size_t recv_bytes_second();
+ ConnectionInfo connection_info();
pthatcher1 2016/06/01 21:39:48 Can you name this stats() instead of connection_in
zhihuang1 2016/06/01 22:34:04 Done.
+
sigslot::signal1<Connection*> SignalStateChange;
// Sent when the connection has decided that it is no longer of value. It
@@ -638,8 +632,8 @@ class Connection : public CandidatePairInterface,
rtc::RateTracker recv_rate_tracker_;
rtc::RateTracker send_rate_tracker_;
- uint32_t sent_packets_discarded_;
- uint32_t sent_packets_total_;
+
+ ConnectionInfo connection_info_;
pthatcher1 2016/06/01 21:39:48 And this stats_ instead of connection_info_?
zhihuang1 2016/06/01 22:34:04 Done.
private:
void MaybeAddPrflxCandidate(ConnectionRequest* request,

Powered by Google App Engine
This is Rietveld 408576698