Fix RTX-configuration test with >2 codecs built.

Fix RTX-configuration test with >2 codecs built.

Fixes WebRtcVideoChannel2Test.DefaultReceiveStreamReconfiguresToUseRtx
under rtc_use_h264=1.

BUG=webrtc:5816
R=danilchap@webrtc.org

Committed: https://crrev.com/d8b0109327b83ee329ebdca46bfc0bb91b8d943d
Cr-Commit-Position: refs/heads/master@{#12703}

[pbos-webrtc, 2016-04-29 18:26:36]

PTAL, see bug for more info, the RTX SSRC should be configured for all
registered payload types and not hard-coded to <=2 payload types (vp8 + vp9).

[pbos-webrtc, 2016-04-29 18:26:41]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 18:26:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938503002/1

[commit-bot: I haz the power, 2016-04-29 19:59:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 19:59:06]

Dry run: This issue passed the CQ dry run.

[danilchap, 2016-05-02 11:16:41]

https://codereview.webrtc.org/1938503002/diff/1/webrtc/media/engine/webrtcvid...
File webrtc/media/engine/webrtcvideoengine2_unittest.cc (right):

https://codereview.webrtc.org/1938503002/diff/1/webrtc/media/engine/webrtcvid...
webrtc/media/engine/webrtcvideoengine2_unittest.cc:1145:
TEST_F(WebRtcVideoChannel2Test, RecvStreamWithSimAndRtx) {
May be update this test too.

https://codereview.webrtc.org/1938503002/diff/1/webrtc/media/engine/webrtcvid...
webrtc/media/engine/webrtcvideoengine2_unittest.cc:2274: EXPECT_EQ(1u,
config.rtp.rtx.ssrcs.size());
Is it still 1 rtx ssrc on send side?

https://codereview.webrtc.org/1938503002/diff/1/webrtc/media/engine/webrtcvid...
webrtc/media/engine/webrtcvideoengine2_unittest.cc:3202: EXPECT_EQ(0u,
recv_stream->GetConfig().rtp.rtx.size())
may be EXPECT_TRUE(....empty()) for consistency with line #3210

[pbos-webrtc, 2016-05-11 22:03:57]

feedback

[pbos-webrtc, 2016-05-11 22:04:27]

PTAL, I hope this is OK, I'm a bit tired

https://codereview.webrtc.org/1938503002/diff/1/webrtc/media/engine/webrtcvid...
File webrtc/media/engine/webrtcvideoengine2_unittest.cc (right):

https://codereview.webrtc.org/1938503002/diff/1/webrtc/media/engine/webrtcvid...
webrtc/media/engine/webrtcvideoengine2_unittest.cc:1145:
TEST_F(WebRtcVideoChannel2Test, RecvStreamWithSimAndRtx) {
On 2016/05/02 11:16:41, danilchap wrote:
> May be update this test too.

Done.

https://codereview.webrtc.org/1938503002/diff/1/webrtc/media/engine/webrtcvid...
webrtc/media/engine/webrtcvideoengine2_unittest.cc:2274: EXPECT_EQ(1u,
config.rtp.rtx.ssrcs.size());
On 2016/05/02 11:16:41, danilchap wrote:
> Is it still 1 rtx ssrc on send side?

Yep, a sender always sends only one payload type, so this is fine.

https://codereview.webrtc.org/1938503002/diff/1/webrtc/media/engine/webrtcvid...
webrtc/media/engine/webrtcvideoengine2_unittest.cc:3202: EXPECT_EQ(0u,
recv_stream->GetConfig().rtp.rtx.size())
On 2016/05/02 11:16:41, danilchap wrote:
> may be EXPECT_TRUE(....empty()) for consistency with line #3210

Done.

[pbos-webrtc, 2016-05-11 22:04:44]

E.g. take an extra-careful look. ;)

[danilchap, 2016-05-12 07:34:31]

lgtm

[pbos-webrtc, 2016-05-12 14:44:51]

Description was changed from

==========
Fix RTX-configuration test with >2 codecs built.

Fixes WebRtcVideoChannel2Test.DefaultReceiveStreamReconfiguresToUseRtx
under rtc_use_h264=1.

BUG=webrtc:5816
R=danilchap@webrtc.org
==========

to

==========
Fix RTX-configuration test with >2 codecs built.

Fixes WebRtcVideoChannel2Test.DefaultReceiveStreamReconfiguresToUseRtx
under rtc_use_h264=1.

BUG=webrtc:5816
R=danilchap@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/d8b0109327b83ee329ebdca46...
==========

[commit-bot: I haz the power, 2016-05-12 14:44:52]

Description was changed from

==========
Fix RTX-configuration test with >2 codecs built.

Fixes WebRtcVideoChannel2Test.DefaultReceiveStreamReconfiguresToUseRtx
under rtc_use_h264=1.

BUG=webrtc:5816
R=danilchap@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/d8b0109327b83ee329ebdca46...
==========

to

==========
Fix RTX-configuration test with >2 codecs built.

Fixes WebRtcVideoChannel2Test.DefaultReceiveStreamReconfiguresToUseRtx
under rtc_use_h264=1.

BUG=webrtc:5816
R=danilchap@webrtc.org

Committed: https://crrev.com/d8b0109327b83ee329ebdca46bfc0bb91b8d943d
Cr-Commit-Position: refs/heads/master@{#12703}
==========

[pbos-webrtc, 2016-05-12 14:44:53]

Committed patchset #2 (id:20001) manually as
d8b0109327b83ee329ebdca46bfc0bb91b8d943d (presubmit successful).

[commit-bot: I haz the power, 2016-05-12 14:44:53]

Patchset 2 (id:??) landed as
https://crrev.com/d8b0109327b83ee329ebdca46bfc0bb91b8d943d
Cr-Commit-Position: refs/heads/master@{#12703}