Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Unified Diff: webrtc/media/engine/webrtcvideoengine2_unittest.cc

Issue 1938503002: Fix RTX-configuration test with >2 codecs built. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: feedback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvideoengine2_unittest.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2_unittest.cc b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
index 0a04fc78caf2e2afe4ca7e5eacad9757456bad7d..3b689916420791290dde27bbc5d16b2102b30d51 100644
--- a/webrtc/media/engine/webrtcvideoengine2_unittest.cc
+++ b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
@@ -1163,11 +1163,13 @@ TEST_F(WebRtcVideoChannel2Test, RecvStreamWithSimAndRtx) {
// Receiver side.
FakeVideoReceiveStream* recv_stream = AddRecvStream(
cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
- ASSERT_GT(recv_stream->GetConfig().rtp.rtx.size(), 0u)
- << "No SSRCs for RTX configured by AddRecvStream.";
- EXPECT_EQ(rtx_ssrcs[0],
- recv_stream->GetConfig().rtp.rtx.begin()->second.ssrc);
- // TODO(pbos): Make sure we set the RTX for correct payloads etc.
+ EXPECT_FALSE(recv_stream->GetConfig().rtp.rtx.empty());
+ EXPECT_EQ(recv_stream->GetConfig().decoders.size(),
+ recv_stream->GetConfig().rtp.rtx.size())
+ << "RTX should be mapped for all decoders/payload types.";
+ for (const auto& kv : recv_stream->GetConfig().rtp.rtx) {
+ EXPECT_EQ(rtx_ssrcs[0], kv.second.ssrc);
+ }
}
TEST_F(WebRtcVideoChannel2Test, RecvStreamWithRtx) {
@@ -3199,7 +3201,7 @@ TEST_F(WebRtcVideoChannel2Test, DefaultReceiveStreamReconfiguresToUseRtx) {
ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
<< "No default receive stream created.";
FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
- EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx.size())
+ EXPECT_TRUE(recv_stream->GetConfig().rtp.rtx.empty())
<< "Default receive stream should not have configured RTX";
EXPECT_TRUE(channel_->AddRecvStream(
@@ -3207,9 +3209,13 @@ TEST_F(WebRtcVideoChannel2Test, DefaultReceiveStreamReconfiguresToUseRtx) {
ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
<< "AddRecvStream should've reconfigured, not added a new receiver.";
recv_stream = fake_call_->GetVideoReceiveStreams()[0];
- ASSERT_GE(2u, recv_stream->GetConfig().rtp.rtx.size());
- EXPECT_EQ(rtx_ssrcs[0],
- recv_stream->GetConfig().rtp.rtx.begin()->second.ssrc);
+ EXPECT_FALSE(recv_stream->GetConfig().rtp.rtx.empty());
+ EXPECT_EQ(recv_stream->GetConfig().decoders.size(),
+ recv_stream->GetConfig().rtp.rtx.size())
+ << "RTX should be mapped for all decoders/payload types.";
+ for (const auto& kv : recv_stream->GetConfig().rtp.rtx) {
+ EXPECT_EQ(rtx_ssrcs[0], kv.second.ssrc);
+ }
}
TEST_F(WebRtcVideoChannel2Test, RejectsAddingStreamsWithMissingSsrcsForRtx) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698