Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1935443002: Revert of Delete webrtc::VideoFrame methods buffer and stride. (Closed)

Created:
4 years, 7 months ago by nisse-webrtc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete webrtc::VideoFrame methods buffer and stride. (patchset #14 id:250001 of https://codereview.webrtc.org/1900673002/ ) Reason for revert: Breaks chrome FYI bots. Original issue's description: > Delete webrtc::VideoFrame methods buffer and stride. > > To make the HasOneRef/IsMutable hack work, also had to change the > video_frame_buffer method to return a const ref to a scoped_ref_ptr, > to not imply an AddRef. > > BUG=webrtc:5682 TBR=perkj@webrtc.org,magjed@webrtc.org,pbos@webrtc.org,pthatcher@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Committed: https://crrev.com/5b3c443d301f2c2f18dac5b02652c08b91ea3828 Cr-Commit-Position: refs/heads/master@{#12558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -418 lines) Patch
M webrtc/api/java/jni/androidmediaencoder_jni.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M webrtc/common_video/i420_video_frame_unittest.cc View 5 chunks +30 lines, -33 lines 0 comments Download
M webrtc/common_video/libyuv/libyuv_unittest.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M webrtc/common_video/libyuv/scaler.cc View 2 chunks +24 lines, -29 lines 0 comments Download
M webrtc/common_video/libyuv/webrtc_libyuv.cc View 7 chunks +82 lines, -106 lines 0 comments Download
M webrtc/common_video/video_frame.cc View 4 chunks +20 lines, -27 lines 0 comments Download
M webrtc/media/base/videoframe.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 2 chunks +20 lines, -21 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_capture/test/video_capture_unittest.cc View 6 chunks +32 lines, -9 lines 0 comments Download
M webrtc/modules/video_capture/video_capture.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc View 4 chunks +16 lines, -27 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 1 chunk +8 lines, -15 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 12 chunks +34 lines, -48 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 2 chunks +10 lines, -16 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M webrtc/modules/video_processing/content_analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M webrtc/modules/video_processing/video_denoiser.cc View 2 chunks +13 lines, -16 lines 0 comments Download
M webrtc/test/frame_generator.cc View 2 chunks +12 lines, -15 lines 0 comments Download
M webrtc/test/frame_generator_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/video/video_capture_input_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/video/video_encoder_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/video_frame.h View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nisse-webrtc
Created Revert of Delete webrtc::VideoFrame methods buffer and stride.
4 years, 7 months ago (2016-04-29 09:38:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935443002/1
4 years, 7 months ago (2016-04-29 09:39:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 09:39:29 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5b3c443d301f2c2f18dac5b02652c08b91ea3828 Cr-Commit-Position: refs/heads/master@{#12558}
4 years, 7 months ago (2016-05-01 22:01:46 UTC) #5
nisse-webrtc
4 years, 7 months ago (2016-05-11 06:11:05 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1963413004/ by nisse@webrtc.org.

The reason for reverting is: I plan to reland this change in a week or two,
after downstream users are updated..

Powered by Google App Engine
This is Rietveld 408576698