Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1934523002: Add root owners to webrtc/OWNERS (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add root owners to webrtc/OWNERS For WebRTC inside Chromium, only the webrtc/ directory is present (as src/third_party/webrtc). That makes it impossible to add DEPS check_deps rules in Chromium without approval of a webrtc.org owner (see https://codereview.chromium.org/1818903004). By having our root owners also be owners in webrtc/, this should be less confusing. NOTRY=True Committed: https://crrev.com/2f5ae664716a53b0198ad682fc2fd4fcffb0ce20 Cr-Commit-Position: refs/heads/master@{#12687}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M webrtc/OWNERS View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
4 years, 7 months ago (2016-04-29 10:24:00 UTC) #2
mflodman
lgtm
4 years, 7 months ago (2016-05-02 07:07:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934523002/1
4 years, 7 months ago (2016-05-11 12:46:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 12:47:42 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 12:47:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f5ae664716a53b0198ad682fc2fd4fcffb0ce20
Cr-Commit-Position: refs/heads/master@{#12687}

Powered by Google App Engine
This is Rietveld 408576698