Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 1929863002: NetEq: Use TickTimer in DelayManager (Closed)

Created:
4 years, 7 months ago by hlundin-webrtc
Modified:
4 years, 7 months ago
Reviewers:
tlegrand-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@delay-pdt-tick-timer
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Use TickTimer in DelayManager This change replaces packet_iat_count_ms_ and max_timer_ms_, two time-counting member variables in DelayManager, with Stopwatch objects obtained from a TickTimer. BUG=webrtc:5608 Committed: https://crrev.com/8f8c96d1924c96f3a5c149ca31883d296ddceca7 Cr-Commit-Position: refs/heads/master@{#12554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -35 lines) Patch
M webrtc/modules/audio_coding/neteq/decision_logic.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/decision_logic_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/delay_manager.h View 5 chunks +10 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/delay_manager.cc View 10 chunks +15 lines, -17 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/delay_manager_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/mock/mock_delay_manager.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
hlundin-webrtc
CL #5. PTAL. Thanks!
4 years, 7 months ago (2016-04-28 08:56:02 UTC) #2
tlegrand-webrtc
LGTM
4 years, 7 months ago (2016-04-28 14:57:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929863002/1
4 years, 7 months ago (2016-04-28 14:58:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-04-28 16:58:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929863002/1
4 years, 7 months ago (2016-04-29 06:17:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 06:19:24 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f8c96d1924c96f3a5c149ca31883d296ddceca7
Cr-Commit-Position: refs/heads/master@{#12554}

Powered by Google App Engine
This is Rietveld 408576698