NetEq: Move counting of generated CNG samples from DecisionLogic

NetEq: Move counting of generated CNG samples from DecisionLogic

The counting is moved to NetEqImpl, and the new counter is realized as a
Stopwatch object. The DecisionLogic class still has to maintain record
of when the CNG period is shortened, in order to reduce the delay. This
is recorded in a new noise_fast_forward_ member in DecisionLogic.

BUG=webrtc:5608
Committed: https://crrev.com/b1fb72bebb2ff0929c466c71f28abfa89fdfb42e
Cr-Commit-Position: refs/heads/master@{#12608}

[hlundin-webrtc, 2016-04-28 15:00:51]

henrik.lundin@webrtc.org changed reviewers:
+ tina.legrand@webrtc.org

[hlundin-webrtc, 2016-04-28 15:00:51]

CL #6 (out of 8 for the TickTimer feature). PTAL. Thanks!

[tlegrand-webrtc, 2016-05-03 11:23:52]

I had a minor question on the naming of the variable, since it isn't consistent
in this CL. I'm fine with the ways it is, though. LGTM

https://codereview.webrtc.org/1914303004/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/decision_logic.h (right):

https://codereview.webrtc.org/1914303004/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/decision_logic.h:82: size_t
noise_samples_played,
Was there any particular reason for renaming from "generated_noise_samples" to
"noise_samples_played"?
In neteq_impl.cc, where this function is called, the variable is still called
"generated_noise_samples".

[hlundin-webrtc, 2016-05-03 11:33:15]

Renaming parameter to generated_noise_samples

[hlundin-webrtc, 2016-05-03 11:34:32]

Thanks!

https://codereview.webrtc.org/1914303004/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/decision_logic.h (right):

https://codereview.webrtc.org/1914303004/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/decision_logic.h:82: size_t
noise_samples_played,
On 2016/05/03 11:23:52, tlegrand-webrtc wrote:
> Was there any particular reason for renaming from "generated_noise_samples" to
> "noise_samples_played"?
> In neteq_impl.cc, where this function is called, the variable is still called
> "generated_noise_samples".

Good point. I'm changing it to generated_noise_samples.

[hlundin-webrtc, 2016-05-03 11:34:37]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-05-03 11:34:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
tina.legrand@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1914303004/#ps20001 (title:
"Renaming parameter to generated_noise_samples")

[commit-bot: I haz the power, 2016-05-03 11:34:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914303004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914303004/20001

[commit-bot: I haz the power, 2016-05-03 12:15:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 12:15:20]

Try jobs failed on following builders:
  linux_msan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/9790)

[hlundin-webrtc, 2016-05-03 15:16:06]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-05-03 15:17:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914303004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914303004/20001

[commit-bot: I haz the power, 2016-05-03 15:18:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-03 15:18:58]

Description was changed from

==========
NetEq: Move counting of generated CNG samples from DecisionLogic

The counting is moved to NetEqImpl, and the new counter is realized as a
Stopwatch object. The DecisionLogic class still has to maintain record
of when the CNG period is shortened, in order to reduce the delay. This
is recorded in a new noise_fast_forward_ member in DecisionLogic.

BUG=webrtc:5608
==========

to

==========
NetEq: Move counting of generated CNG samples from DecisionLogic

The counting is moved to NetEqImpl, and the new counter is realized as a
Stopwatch object. The DecisionLogic class still has to maintain record
of when the CNG period is shortened, in order to reduce the delay. This
is recorded in a new noise_fast_forward_ member in DecisionLogic.

BUG=webrtc:5608

Committed: https://crrev.com/b1fb72bebb2ff0929c466c71f28abfa89fdfb42e
Cr-Commit-Position: refs/heads/master@{#12608}
==========

[commit-bot: I haz the power, 2016-05-03 15:18:59]

Patchset 2 (id:??) landed as
https://crrev.com/b1fb72bebb2ff0929c466c71f28abfa89fdfb42e
Cr-Commit-Position: refs/heads/master@{#12608}