webrtc/media/media.gyp - Issue 1928653005: Fix all -Wnon-virtual-dtor warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/media.gyp

Issue 1928653005: Fix all -Wnon-virtual-dtor warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/media.gyp

diff --git a/webrtc/media/media.gyp b/webrtc/media/media.gyp

index 230d33ab38f0c30d6d09f4c3fb3a55b1c2c28fa5..deb730a85a8c7d2b1b16a9709df4fd42627a36a7 100644

--- a/webrtc/media/media.gyp

+++ b/webrtc/media/media.gyp

@@ -107,7 +107,6 @@

'-Wextra',

'cflags_cc!': [

- '-Wnon-virtual-dtor',

'-Woverloaded-virtual',

'msvs_disabled_warnings': [

@@ -248,11 +247,6 @@

'engine/fakewebrtcvideoengine.h',

'engine/fakewebrtcvoiceengine.h',

- # TODO(kjellander): Make the code compile without disabling these flags.

- # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307

- 'cflags_cc!': [

- '-Wnon-virtual-dtor',

- ],

}, # target rtc_unittest_main

{

'target_name': 'rtc_media_unittests',

@@ -291,7 +285,6 @@

'-Wno-sign-compare',

'cflags_cc!': [

- '-Wnon-virtual-dtor',

'-Woverloaded-virtual',

'msvs_disabled_warnings': [

« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2.h ('k') | webrtc/p2p/base/turnserver.h » ('j') | no next file with comments »