webrtc/api/peerconnectionfactory.h - Issue 1921653002: Enable -Winconsistent-missing-override flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/peerconnectionfactory.h

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/peerconnectionfactory.h

diff --git a/webrtc/api/peerconnectionfactory.h b/webrtc/api/peerconnectionfactory.h

index b47f75a7ce9ea11fa7403a7308111719cc062bcb..b451668771d02c4e7e616289c4ddbe4e9ffee91d 100644

--- a/webrtc/api/peerconnectionfactory.h

+++ b/webrtc/api/peerconnectionfactory.h

@@ -34,7 +34,7 @@ typedef rtc::RefCountedObject<DtlsIdentityStoreImpl>

class PeerConnectionFactory : public PeerConnectionFactoryInterface {

public:

- virtual void SetOptions(const Options& options) {

+ void SetOptions(const Options& options) override {

options_ = options;

}