webrtc/api/peerconnectioninterface_unittest.cc - Issue 1921653002: Enable -Winconsistent-missing-override flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/peerconnectioninterface_unittest.cc

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/peerconnectioninterface_unittest.cc

diff --git a/webrtc/api/peerconnectioninterface_unittest.cc b/webrtc/api/peerconnectioninterface_unittest.cc

index 14a067995b42205c698b5581d32b73f1972e1449..1b9b85b982e88c60096668c9ae7f55558704c775 100644

--- a/webrtc/api/peerconnectioninterface_unittest.cc

+++ b/webrtc/api/peerconnectioninterface_unittest.cc

@@ -425,8 +425,8 @@ class MockPeerConnectionObserver : public PeerConnectionObserver {

state_ = pc_->signaling_state();

}

- virtual void OnSignalingChange(

- PeerConnectionInterface::SignalingState new_state) {

+ void OnSignalingChange(

+ PeerConnectionInterface::SignalingState new_state) override {

EXPECT_EQ(pc_->signaling_state(), new_state);

state_ = new_state;

}