webrtc/api/java/jni/peerconnection_jni.cc - Issue 1921653002: Enable -Winconsistent-missing-override flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/java/jni/peerconnection_jni.cc

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/java/jni/peerconnection_jni.cc

diff --git a/webrtc/api/java/jni/peerconnection_jni.cc b/webrtc/api/java/jni/peerconnection_jni.cc

index b0757e20bc0a34bbb952fbddc22891eca554a62f..491d41f277645b82695518ff780edde8c69ee78c 100644

--- a/webrtc/api/java/jni/peerconnection_jni.cc

+++ b/webrtc/api/java/jni/peerconnection_jni.cc

@@ -203,7 +203,7 @@ class PCOJava : public PeerConnectionObserver {

}

void OnIceCandidatesRemoved(

- const std::vector<cricket::Candidate>& candidates) {

+ const std::vector<cricket::Candidate>& candidates) override {

ScopedLocalRefFrame local_ref_frame(jni());

jobjectArray candidates_array = ToJavaCandidateArray(jni(), candidates);

jmethodID m =