Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: webrtc/api/java/jni/peerconnection_jni.cc

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 jobject j_candidate = jni()->NewObject(candidate_class, ctor, j_mid, 196 jobject j_candidate = jni()->NewObject(candidate_class, ctor, j_mid,
197 candidate->sdp_mline_index(), j_sdp); 197 candidate->sdp_mline_index(), j_sdp);
198 CHECK_EXCEPTION(jni()) << "error during NewObject"; 198 CHECK_EXCEPTION(jni()) << "error during NewObject";
199 jmethodID m = GetMethodID(jni(), *j_observer_class_, 199 jmethodID m = GetMethodID(jni(), *j_observer_class_,
200 "onIceCandidate", "(Lorg/webrtc/IceCandidate;)V"); 200 "onIceCandidate", "(Lorg/webrtc/IceCandidate;)V");
201 jni()->CallVoidMethod(*j_observer_global_, m, j_candidate); 201 jni()->CallVoidMethod(*j_observer_global_, m, j_candidate);
202 CHECK_EXCEPTION(jni()) << "error during CallVoidMethod"; 202 CHECK_EXCEPTION(jni()) << "error during CallVoidMethod";
203 } 203 }
204 204
205 void OnIceCandidatesRemoved( 205 void OnIceCandidatesRemoved(
206 const std::vector<cricket::Candidate>& candidates) { 206 const std::vector<cricket::Candidate>& candidates) override {
207 ScopedLocalRefFrame local_ref_frame(jni()); 207 ScopedLocalRefFrame local_ref_frame(jni());
208 jobjectArray candidates_array = ToJavaCandidateArray(jni(), candidates); 208 jobjectArray candidates_array = ToJavaCandidateArray(jni(), candidates);
209 jmethodID m = 209 jmethodID m =
210 GetMethodID(jni(), *j_observer_class_, "onIceCandidatesRemoved", 210 GetMethodID(jni(), *j_observer_class_, "onIceCandidatesRemoved",
211 "([Lorg/webrtc/IceCandidate;)V"); 211 "([Lorg/webrtc/IceCandidate;)V");
212 jni()->CallVoidMethod(*j_observer_global_, m, candidates_array); 212 jni()->CallVoidMethod(*j_observer_global_, m, candidates_array);
213 CHECK_EXCEPTION(jni()) << "Error during CallVoidMethod"; 213 CHECK_EXCEPTION(jni()) << "Error during CallVoidMethod";
214 } 214 }
215 215
216 void OnSignalingChange( 216 void OnSignalingChange(
(...skipping 1990 matching lines...) Expand 10 before | Expand all | Expand 10 after
2207 return JavaStringFromStdString( 2207 return JavaStringFromStdString(
2208 jni, 2208 jni,
2209 reinterpret_cast<RtpReceiverInterface*>(j_rtp_receiver_pointer)->id()); 2209 reinterpret_cast<RtpReceiverInterface*>(j_rtp_receiver_pointer)->id());
2210 } 2210 }
2211 2211
2212 JOW(void, RtpReceiver_free)(JNIEnv* jni, jclass, jlong j_rtp_receiver_pointer) { 2212 JOW(void, RtpReceiver_free)(JNIEnv* jni, jclass, jlong j_rtp_receiver_pointer) {
2213 reinterpret_cast<RtpReceiverInterface*>(j_rtp_receiver_pointer)->Release(); 2213 reinterpret_cast<RtpReceiverInterface*>(j_rtp_receiver_pointer)->Release();
2214 } 2214 }
2215 2215
2216 } // namespace webrtc_jni 2216 } // namespace webrtc_jni
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698