Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1921463002: Replace use of GetMacOSStatusErrorString (deprecated) with use of NSOSStatusErrorDomain. (Closed)

Created:
4 years, 8 months ago by tommi
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace use of GetMacOSStatusErrorString (deprecated) with use of NSOSStatusErrorDomain. This should unblock the roll. TBR=kjellander@webrtc.org Committed: https://crrev.com/09ca02ea5c315e7809a1d6e8fd784c13ce1337d4 Cr-Commit-Position: refs/heads/master@{#12479}

Patch Set 1 #

Patch Set 2 : Fix guard #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -14 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/base.gyp View 1 chunk +11 lines, -0 lines 2 comments Download
M webrtc/base/logging.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M webrtc/base/logging.cc View 1 chunk +2 lines, -4 lines 0 comments Download
A + webrtc/base/logging_mac.mm View 2 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
tommi
4 years, 8 months ago (2016-04-24 13:53:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921463002/1
4 years, 8 months ago (2016-04-24 13:54:09 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/6952) ios64_sim_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 8 months ago (2016-04-24 13:55:19 UTC) #5
tommi
Fix guard
4 years, 8 months ago (2016-04-24 14:00:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921463002/20001
4 years, 8 months ago (2016-04-24 14:00:39 UTC) #8
tommi
Committed patchset #2 (id:20001) manually as 09ca02ea5c315e7809a1d6e8fd784c13ce1337d4 (presubmit successful).
4 years, 8 months ago (2016-04-24 15:32:56 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/09ca02ea5c315e7809a1d6e8fd784c13ce1337d4 Cr-Commit-Position: refs/heads/master@{#12479}
4 years, 8 months ago (2016-04-24 15:33:00 UTC) #12
kjellander_webrtc
Whoa, thanks for this. Adding grunell mostly FYI since I don't have any deep knowledge ...
4 years, 8 months ago (2016-04-25 04:26:44 UTC) #14
kjellander_webrtc
https://codereview.webrtc.org/1921463002/diff/20001/webrtc/base/base.gyp File webrtc/base/base.gyp (right): https://codereview.webrtc.org/1921463002/diff/20001/webrtc/base/base.gyp#newcode171 webrtc/base/base.gyp:171: '-framework Foundation', I'm missing a corresponding public_deps entry for ...
4 years, 8 months ago (2016-04-25 04:47:43 UTC) #15
kjellander_webrtc
Created a CL for the fix now (https://codereview.webrtc.org/1921513002) https://codereview.webrtc.org/1921463002/diff/20001/webrtc/base/base.gyp File webrtc/base/base.gyp (right): https://codereview.webrtc.org/1921463002/diff/20001/webrtc/base/base.gyp#newcode171 webrtc/base/base.gyp:171: '-framework ...
4 years, 8 months ago (2016-04-25 05:42:37 UTC) #16
Henrik Grunell WebRTC
4 years, 8 months ago (2016-04-25 08:14:27 UTC) #17
Message was sent while issue was closed.
I'm not really familiar with the parts changed. But, fwiw, lgtm.

Powered by Google App Engine
This is Rietveld 408576698