GN: Fix dependency for rtc_base_approved

GN: Fix dependency for rtc_base_approved

In https://codereview.webrtc.org/1921463002/ a dependency
on Foundation.framework was added to rtc_base_approved for the
GYP build but not for the GN build. This was fixed for some
targets in https://codereview.webrtc.org/1919673002/ but the proper
fix is to introduce an all_dependent_configs entry for rtc_base_approved.

NOTRY=True

Committed: https://crrev.com/84ba8b6f4567e418b4ede67c3b7583e9952411b5
Cr-Commit-Position: refs/heads/master@{#12483}

[kjellander_webrtc, 2016-04-25 05:19:17]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-04-25 05:40:22]

Patchset #1 (id:20001) has been deleted

[kjellander_webrtc, 2016-04-25 05:41:29]

Description was changed from

==========
GN: Fix dependencies for rtc_base_approved

In https://codereview.webrtc.org/1921463002/ a dependency
on Foundation.framework was added to rtc_base_approved for the
GYP build but not for the GN build. This was fixed for some
targets in https://codereview.webrtc.org/1919673002/ but the proper
fix is to introduce an all_dependent_configs entry for rtc_base_approved.
==========

to

==========
GN: Fix dependencies for rtc_base_approved

In https://codereview.webrtc.org/1921463002/ a dependency
on Foundation.framework was added to rtc_base_approved for the
GYP build but not for the GN build. This was fixed for some
targets in https://codereview.webrtc.org/1919673002/ but the proper
fix is to introduce an all_dependent_configs entry for rtc_base_approved.

NOTRY=True
==========

[kjellander_webrtc, 2016-04-25 05:41:55]

Description was changed from

==========
GN: Fix dependencies for rtc_base_approved

In https://codereview.webrtc.org/1921463002/ a dependency
on Foundation.framework was added to rtc_base_approved for the
GYP build but not for the GN build. This was fixed for some
targets in https://codereview.webrtc.org/1919673002/ but the proper
fix is to introduce an all_dependent_configs entry for rtc_base_approved.

NOTRY=True
==========

to

==========
GN: Fix dependency for rtc_base_approved

In https://codereview.webrtc.org/1921463002/ a dependency
on Foundation.framework was added to rtc_base_approved for the
GYP build but not for the GN build. This was fixed for some
targets in https://codereview.webrtc.org/1919673002/ but the proper
fix is to introduce an all_dependent_configs entry for rtc_base_approved.

NOTRY=True
==========

[kjellander_webrtc, 2016-04-25 05:42:05]

kjellander@webrtc.org changed reviewers:
+ tommi@webrtc.org

[kjellander_webrtc, 2016-04-25 05:44:10]

https://codereview.webrtc.org/1921513002/diff/40001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/1921513002/diff/40001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:15: config("rtc_base_approved_all_dependent_config") {
I updated the rtc_base target to use the same style in
https://codereview.webrtc.org/1914913002/

[tommi, 2016-04-25 05:52:46]

lgtm

[kjellander_webrtc, 2016-04-25 05:57:08]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-04-25 05:57:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921513002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921513002/40001

[commit-bot: I haz the power, 2016-04-25 06:03:10]

Description was changed from

==========
GN: Fix dependency for rtc_base_approved

In https://codereview.webrtc.org/1921463002/ a dependency
on Foundation.framework was added to rtc_base_approved for the
GYP build but not for the GN build. This was fixed for some
targets in https://codereview.webrtc.org/1919673002/ but the proper
fix is to introduce an all_dependent_configs entry for rtc_base_approved.

NOTRY=True
==========

to

==========
GN: Fix dependency for rtc_base_approved

In https://codereview.webrtc.org/1921463002/ a dependency
on Foundation.framework was added to rtc_base_approved for the
GYP build but not for the GN build. This was fixed for some
targets in https://codereview.webrtc.org/1919673002/ but the proper
fix is to introduce an all_dependent_configs entry for rtc_base_approved.

NOTRY=True
==========

[commit-bot: I haz the power, 2016-04-25 06:03:11]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-04-25 06:03:22]

Description was changed from

==========
GN: Fix dependency for rtc_base_approved

In https://codereview.webrtc.org/1921463002/ a dependency
on Foundation.framework was added to rtc_base_approved for the
GYP build but not for the GN build. This was fixed for some
targets in https://codereview.webrtc.org/1919673002/ but the proper
fix is to introduce an all_dependent_configs entry for rtc_base_approved.

NOTRY=True
==========

to

==========
GN: Fix dependency for rtc_base_approved

In https://codereview.webrtc.org/1921463002/ a dependency
on Foundation.framework was added to rtc_base_approved for the
GYP build but not for the GN build. This was fixed for some
targets in https://codereview.webrtc.org/1919673002/ but the proper
fix is to introduce an all_dependent_configs entry for rtc_base_approved.

NOTRY=True

Committed: https://crrev.com/84ba8b6f4567e418b4ede67c3b7583e9952411b5
Cr-Commit-Position: refs/heads/master@{#12483}
==========

[commit-bot: I haz the power, 2016-04-25 06:03:23]

Patchset 1 (id:??) landed as
https://crrev.com/84ba8b6f4567e418b4ede67c3b7583e9952411b5
Cr-Commit-Position: refs/heads/master@{#12483}