Replace scoped_ptr with unique_ptr in webrtc/base/

Replace scoped_ptr with unique_ptr in webrtc/base/

This propagated into various other places. Also had to #include headers that
were implicitly pulled by "scoped_ptr.h".

BUG=webrtc:5520
Committed: https://crrev.com/555604a7463c6a6677f54aff340e7852a16b3c58
Cr-Commit-Position: refs/heads/master@{#12501}

[joachim, 2016-04-25 22:01:29]

jbauch@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[joachim, 2016-04-25 22:01:31]

I saw your discussion in the referenced bug, but as I already had a couple of
local patches that were replacing scoped_ptr with unique_ptr in webrtc/base I
decided to finish it up and submit as CL...

It probably touches a couple of interfaces with Chromium (e.g.
DtlsIdentityRequestObserver) but these should be trivial to update when rolling
the update into Chromium.

Anyway, ptal.

[kwiberg-webrtc, 2016-04-25 22:37:31]

kwiberg@webrtc.org changed reviewers:
+ tommi@webrtc.org

[kwiberg-webrtc, 2016-04-25 22:37:31]

kwiberg@webrtc.org changed required reviewers:
+ tommi@webrtc.org

[kwiberg-webrtc, 2016-04-25 22:37:33]

lgtm, but please hold off landing this until after I've landed
https://codereview.webrtc.org/1797463002/ (which in turn is just waiting for
https://codereview.chromium.org/1921553002/ to land).

If you don't wait, you'll break Chromium, as you say, and likely other WebRTC
users too. Which would be a shame, since I've tried to carefully order changes
so that that won't happen.

(Note: Adding tommi@ as reviewer, since I don't OWN any of these files.)

https://codereview.webrtc.org/1920043002/diff/20001/webrtc/base/fakenetwork.h
File webrtc/base/fakenetwork.h (right):

https://codereview.webrtc.org/1920043002/diff/20001/webrtc/base/fakenetwork.h...
webrtc/base/fakenetwork.h:105: prefix_length, it->second));
Looks like you forgot to run "git cl format".

[joachim, 2016-04-25 23:27:01]

Thanks for the fast feedback!

On 2016/04/25 22:37:33, kwiberg-webrtc wrote:
> lgtm, but please hold off landing this until after I've landed
> https://codereview.webrtc.org/1797463002/ (which in turn is just waiting for
> https://codereview.chromium.org/1921553002/ to land).
> 
> If you don't wait, you'll break Chromium, as you say, and likely other WebRTC
> users too. Which would be a shame, since I've tried to carefully order changes
> so that that won't happen.

Yeah sure. I CC'd the issue and will wait for your CLs (and will double-check
with you before landing this).

> (Note: Adding tommi@ as reviewer, since I don't OWN any of these files.)

As you did the other scoped_ptr -> unique_ptr changes, I wanted to get some
feedback from you first before adding an OWNER, so thanks for doing this.

> https://codereview.webrtc.org/1920043002/diff/20001/webrtc/base/fakenetwork.h
> File webrtc/base/fakenetwork.h (right):
> 
>
https://codereview.webrtc.org/1920043002/diff/20001/webrtc/base/fakenetwork.h...
> webrtc/base/fakenetwork.h:105: prefix_length, it->second));
> Looks like you forgot to run "git cl format".

Thanks, just updated the CL.

[tommi, 2016-04-26 07:41:13]

Thanks for doing this. Please ping me back when you want to land.

[kwiberg-webrtc, 2016-04-26 08:10:53]

On 2016/04/26 07:41:13, tommi-webrtc wrote:
> Thanks for doing this. Please ping me back when you want to land.

Actually, right away. I was able to land the type alias CL a couple of hours
ago, and all the bots seem to like it.

[tommi, 2016-04-26 08:27:33]

lgtm

[kwiberg-webrtc, 2016-04-26 08:44:28]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2016-04-26 08:44:29]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1920043002/#ps40001 (title:
"git cl format")

[commit-bot: I haz the power, 2016-04-26 08:44:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920043002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920043002/40001

[commit-bot: I haz the power, 2016-04-26 08:49:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 08:49:18]

Try jobs failed on following builders:
  mac_compile_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)

[kwiberg-webrtc, 2016-04-26 09:08:10]

On 2016/04/26 08:49:18, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_compile_dbg on tryserver.webrtc (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)

Sorry, I attempted to land this for you (since I wanted to build on top of it),
but you need to get rid of that extra specialization of FunctorMessageHandler
first.

[joachim, 2016-04-26 09:08:53]

On 2016/04/26 09:08:10, kwiberg-webrtc wrote:
> On 2016/04/26 08:49:18, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   mac_compile_dbg on tryserver.webrtc (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
> 
> Sorry, I attempted to land this for you (since I wanted to build on top of
it),
> but you need to get rid of that extra specialization of FunctorMessageHandler
> first.

Just rebased it, ptal.

[kwiberg-webrtc, 2016-04-26 09:11:36]

On 2016/04/26 09:08:53, joachim wrote:
> On 2016/04/26 09:08:10, kwiberg-webrtc wrote:
> > On 2016/04/26 08:49:18, commit-bot: I haz the power wrote:
> > > Try jobs failed on following builders:
> > >   mac_compile_dbg on tryserver.webrtc (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
> > 
> > Sorry, I attempted to land this for you (since I wanted to build on top of
> it),
> > but you need to get rid of that extra specialization of
FunctorMessageHandler
> > first.
> 
> Just rebased it, ptal.

lgtm!

[joachim, 2016-04-26 09:12:19]

The CQ bit was checked by jbauch@webrtc.org

[joachim, 2016-04-26 09:12:20]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1920043002/#ps60001 (title:
"Rebased")

[commit-bot: I haz the power, 2016-04-26 09:12:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920043002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920043002/60001

[commit-bot: I haz the power, 2016-04-26 10:13:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-26 10:13:35]

Description was changed from

==========
Replace scoped_ptr with unique_ptr in webrtc/base/

This propagated into various other places. Also had to #include headers that
were implicitly pulled by "scoped_ptr.h".

BUG=webrtc:5520
==========

to

==========
Replace scoped_ptr with unique_ptr in webrtc/base/

This propagated into various other places. Also had to #include headers that
were implicitly pulled by "scoped_ptr.h".

BUG=webrtc:5520

Committed: https://crrev.com/555604a7463c6a6677f54aff340e7852a16b3c58
Cr-Commit-Position: refs/heads/master@{#12501}
==========

[commit-bot: I haz the power, 2016-04-26 10:13:37]

Patchset 4 (id:??) landed as
https://crrev.com/555604a7463c6a6677f54aff340e7852a16b3c58
Cr-Commit-Position: refs/heads/master@{#12501}