Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: webrtc/base/asyncudpsocket_unittest.cc

Issue 1920043002: Replace scoped_ptr with unique_ptr in webrtc/base/ (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/asyncudpsocket.cc ('k') | webrtc/base/criticalsection_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include <memory>
11 #include <string> 12 #include <string>
12 13
13 #include "webrtc/base/asyncudpsocket.h" 14 #include "webrtc/base/asyncudpsocket.h"
14 #include "webrtc/base/gunit.h" 15 #include "webrtc/base/gunit.h"
15 #include "webrtc/base/physicalsocketserver.h" 16 #include "webrtc/base/physicalsocketserver.h"
16 #include "webrtc/base/scoped_ptr.h"
17 #include "webrtc/base/virtualsocketserver.h" 17 #include "webrtc/base/virtualsocketserver.h"
18 18
19 namespace rtc { 19 namespace rtc {
20 20
21 class AsyncUdpSocketTest 21 class AsyncUdpSocketTest
22 : public testing::Test, 22 : public testing::Test,
23 public sigslot::has_slots<> { 23 public sigslot::has_slots<> {
24 public: 24 public:
25 AsyncUdpSocketTest() 25 AsyncUdpSocketTest()
26 : pss_(new rtc::PhysicalSocketServer), 26 : pss_(new rtc::PhysicalSocketServer),
27 vss_(new rtc::VirtualSocketServer(pss_.get())), 27 vss_(new rtc::VirtualSocketServer(pss_.get())),
28 socket_(vss_->CreateAsyncSocket(SOCK_DGRAM)), 28 socket_(vss_->CreateAsyncSocket(SOCK_DGRAM)),
29 udp_socket_(new AsyncUDPSocket(socket_)), 29 udp_socket_(new AsyncUDPSocket(socket_)),
30 ready_to_send_(false) { 30 ready_to_send_(false) {
31 udp_socket_->SignalReadyToSend.connect(this, 31 udp_socket_->SignalReadyToSend.connect(this,
32 &AsyncUdpSocketTest::OnReadyToSend); 32 &AsyncUdpSocketTest::OnReadyToSend);
33 } 33 }
34 34
35 void OnReadyToSend(rtc::AsyncPacketSocket* socket) { 35 void OnReadyToSend(rtc::AsyncPacketSocket* socket) {
36 ready_to_send_ = true; 36 ready_to_send_ = true;
37 } 37 }
38 38
39 protected: 39 protected:
40 scoped_ptr<PhysicalSocketServer> pss_; 40 std::unique_ptr<PhysicalSocketServer> pss_;
41 scoped_ptr<VirtualSocketServer> vss_; 41 std::unique_ptr<VirtualSocketServer> vss_;
42 AsyncSocket* socket_; 42 AsyncSocket* socket_;
43 scoped_ptr<AsyncUDPSocket> udp_socket_; 43 std::unique_ptr<AsyncUDPSocket> udp_socket_;
44 bool ready_to_send_; 44 bool ready_to_send_;
45 }; 45 };
46 46
47 TEST_F(AsyncUdpSocketTest, OnWriteEvent) { 47 TEST_F(AsyncUdpSocketTest, OnWriteEvent) {
48 EXPECT_FALSE(ready_to_send_); 48 EXPECT_FALSE(ready_to_send_);
49 socket_->SignalWriteEvent(socket_); 49 socket_->SignalWriteEvent(socket_);
50 EXPECT_TRUE(ready_to_send_); 50 EXPECT_TRUE(ready_to_send_);
51 } 51 }
52 52
53 } // namespace rtc 53 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/asyncudpsocket.cc ('k') | webrtc/base/criticalsection_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698