Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1917713002: Add logging of supported video codecs. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add logging of supported video codecs. In particular, logs which codecs are supported by the hardware encoder factory separately. BUG= R=danilchap@webrtc.org Committed: https://crrev.com/e6cd03df9436bf3aa9c1d9b17cda8679377f6fc2 Cr-Commit-Position: refs/heads/master@{#12488}

Patch Set 1 #

Patch Set 2 : out.str() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M webrtc/media/engine/webrtcvideoengine2.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
pbos-webrtc
PTAL
4 years, 8 months ago (2016-04-24 18:22:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917713002/1
4 years, 8 months ago (2016-04-24 18:22:32 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/10825) win_rel on ...
4 years, 8 months ago (2016-04-24 18:24:27 UTC) #5
pbos-webrtc
out.str()
4 years, 8 months ago (2016-04-24 18:29:00 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917713002/20001
4 years, 8 months ago (2016-04-24 18:29:37 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-24 19:28:22 UTC) #11
danilchap
lgtm
4 years, 8 months ago (2016-04-25 08:04:14 UTC) #12
pbos-webrtc
Committed patchset #2 (id:20001) manually as e6cd03df9436bf3aa9c1d9b17cda8679377f6fc2 (presubmit successful).
4 years, 8 months ago (2016-04-25 09:04:03 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 09:04:06 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e6cd03df9436bf3aa9c1d9b17cda8679377f6fc2
Cr-Commit-Position: refs/heads/master@{#12488}

Powered by Google App Engine
This is Rietveld 408576698