Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: webrtc/media/engine/webrtcvideoengine2.cc

Issue 1917713002: Add logging of supported video codecs. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: out.str() Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvideoengine2.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2.cc b/webrtc/media/engine/webrtcvideoengine2.cc
index 46b033e4f2d08cc0074208717dda53a9f62df5f1..5e25a6587a1b8b755c1ee28d382fade09fd55a4f 100644
--- a/webrtc/media/engine/webrtcvideoengine2.cc
+++ b/webrtc/media/engine/webrtcvideoengine2.cc
@@ -630,12 +630,19 @@ std::vector<VideoCodec> WebRtcVideoEngine2::GetSupportedCodecs() const {
std::vector<VideoCodec> supported_codecs = DefaultVideoCodecList();
if (external_encoder_factory_ == NULL) {
+ LOG(LS_INFO) << "Supported codecs: "
+ << CodecVectorToString(supported_codecs);
return supported_codecs;
}
+ std::stringstream out;
const std::vector<WebRtcVideoEncoderFactory::VideoCodec>& codecs =
external_encoder_factory_->codecs();
for (size_t i = 0; i < codecs.size(); ++i) {
+ out << codecs[i].name;
+ if (i != codecs.size() - 1) {
+ out << ", ";
+ }
// Don't add internally-supported codecs twice.
if (CodecIsInternallySupported(codecs[i].name)) {
continue;
@@ -653,6 +660,10 @@ std::vector<VideoCodec> WebRtcVideoEngine2::GetSupportedCodecs() const {
AddDefaultFeedbackParams(&codec);
supported_codecs.push_back(codec);
}
+ LOG(LS_INFO) << "Supported codecs (incl. external codecs): "
+ << CodecVectorToString(supported_codecs);
+ LOG(LS_INFO) << "Codecs supported by the external encoder factory: "
+ << out.str();
return supported_codecs;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698