Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1914913002: GN: Refactor webrtc/base/BUILD.gn (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Refactor webrtc/base/BUILD.gn Move the all_dependent_configs configurations into a single config for better readability. Sync the Mac and iOS frameworks between the GYP and the GN build. Many entries that used to be default included in https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD.gn are no longer implicitly added for Mac, so to ensure they are they're added back for the Mac build. NOTRY=True Committed: https://crrev.com/b1f1406e0667ea5247d36f0b0555e336fb2e1549 Cr-Commit-Position: refs/heads/master@{#12484}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -37 lines) Patch
M webrtc/base/BUILD.gn View 4 chunks +25 lines, -37 lines 3 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
https://codereview.webrtc.org/1914913002/diff/1/webrtc/base/BUILD.gn File webrtc/base/BUILD.gn (left): https://codereview.webrtc.org/1914913002/diff/1/webrtc/base/BUILD.gn#oldcode46 webrtc/base/BUILD.gn:46: "AVFoundation.framework", This no longer exists in base.gyp (only for ...
4 years, 8 months ago (2016-04-25 05:37:56 UTC) #2
perkj_webrtc
lgtm
4 years, 8 months ago (2016-04-25 06:46:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914913002/1
4 years, 8 months ago (2016-04-25 06:50:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 07:01:39 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 07:01:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1f1406e0667ea5247d36f0b0555e336fb2e1549
Cr-Commit-Position: refs/heads/master@{#12484}

Powered by Google App Engine
This is Rietveld 408576698