GN: Refactor webrtc/base/BUILD.gn

webrtc/base/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/crypto.gni")
 import("//build/config/ui.gni")
@@ skipping 23 matching lines @@
   defines = [ "NO_MAIN_THREAD_WRAPPING" ]
 }
 
 config("openssl_config") {
   defines = [
     "SSL_USE_OPENSSL",
     "HAVE_OPENSSL_SSL_H",
   ]
 }
 
-config("ios_config") {
-  libs = [
-    "AVFoundation.framework",

[kjellander_webrtc, 2016/04/25 05:37:56]

This no longer exists in base.gyp (only for the _objc targets which don't have
any GN representatives due GN limitations so far).

-    "CFNetwork.framework",
+config("rtc_base_all_dependent_config") {
+  if (is_ios) {
+    libs = [
+      "CFNetwork.framework",
 
-    #"Foundation.framework",  # Already included in //build/config:default_libs.
-    "Security.framework",
-    "SystemConfiguration.framework",
-
-    #"UIKit.framework",  # Already included in //build/config:default_libs.

[kjellander_webrtc, 2016/04/25 05:37:56]

No longer in //build/config:default_libs

-  ]
-}
-
-config("mac_config") {
-  libs = [
-    "Cocoa.framework",
-
-    #"Foundation.framework",  # Already included in //build/config:default_libs.

[kjellander_webrtc, 2016/04/25 05:37:56]

Include these again (turns out it was a very good idea to leave them in here
commented when I initially wrote this).

-    #"IOKit.framework",  # Already included in //build/config:default_libs.
-    #"Security.framework",  # Already included in //build/config:default_libs.
-    "SystemConfiguration.framework",
-  ]
-}
-
-config("mac_x86_config") {
-  libs = [
-    #"Carbon.framework",  # Already included in //build/config:default_libs.
-  ]
+      #"Foundation.framework",  # Already in //build/config:default_libs.
+      "Security.framework",
+      "SystemConfiguration.framework",
+      "UIKit.framework",  # Already in //build/config:default_libs.
+    ]
+  }
+  if (is_mac) {
+    libs = [
+      "Cocoa.framework",
+      "Foundation.framework",
+      "IOKit.framework",
+      "Security.framework",
+      "SystemConfiguration.framework",
+    ]
+    if (current_cpu == "x86") {
+      libs = [ "Carbon.framework" ]  # Already in //build/config:default_libs.
+    }
+  }
 }
 
 if (is_linux && !build_with_chromium) {
   # Provides the same functionality as the //crypto:platform target, which
   # WebRTC cannot use as we don't sync src/crypto from Chromium.
   group("linux_system_ssl") {
     deps = [
       "//third_party/boringssl",
     ]
   }
@@ skipping 113 matching lines @@
     ":openssl_config",
     ":rtc_base_config",
   ]
 
   public_configs = [
     "..:common_inherited_config",
     ":openssl_config",
     ":rtc_base_config",
   ]
 
+  all_dependent_configs = [ ":rtc_base_all_dependent_config" ]
+
   defines = [ "LOGGING=1" ]
 
   sources = [
     "arraysize.h",
     "asyncfile.cc",
     "asyncfile.h",
     "asyncinvoker-inl.h",
     "asyncinvoker.cc",
     "asyncinvoker.h",
     "asyncpacketsocket.cc",
@@ skipping 266 matching lines @@
       "ifaddrs-android.h",
     ]
 
     libs += [
       "log",
       "GLESv2",
     ]
   }
 
   if (is_ios || is_mac) {
-    if (is_ios) {
-      all_dependent_configs = [ ":ios_config" ]
-    }
     sources += [
       "maccocoathreadhelper.h",
       "maccocoathreadhelper.mm",
       "macconversion.cc",
       "macconversion.h",
       "macifaddrs_converter.cc",
       "scoped_autorelease_pool.h",
       "scoped_autorelease_pool.mm",
     ]
   }
@@ skipping 18 matching lines @@
       "dl",
       "rt",
     ]
   }
 
   if (is_mac) {
     sources += [
       "macutils.cc",
       "macutils.h",
     ]
-
-    all_dependent_configs = [ ":mac_config" ]
-
-    if (current_cpu == "x86") {
-      all_dependent_configs += [ ":mac_x86_config" ]
-    }
   }
 
   if (is_win) {
     sources += [
       "win32.cc",
       "win32.h",
       "win32filesystem.cc",
       "win32filesystem.h",
       "win32securityerrors.cc",
       "win32window.cc",
@@ skipping 90 matching lines @@
       ]
     }
   }
 }
 
 source_set("gtest_prod") {
   sources = [
     "gtest_prod_util.h",
   ]
 }