Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1911403002:
Move bind.h to rtc_base_approved. (Closed)
|
Created:
4 years, 8 months ago by tommi Modified:
4 years, 8 months ago Reviewers:
perkj_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionMove bind.h to rtc_base_approved.
This is more a correction than a change since bind.h was incorrectly not
a part of rtc_base when building with Chromium while still being used
(since it's a header file only). The only dependencies that bind.h has,
are in rtc_base_approved, so there's no need to restrict usage of it to
rtc_base users only.
NOTRY=true
TBR=perkj
NO_DEPENDENCY_CHECKS=true
Committed: https://crrev.com/cc4fddeba87ffa999781ab205839aebe35e29470
Cr-Commit-Position: refs/heads/master@{#12474}
Patch Set 1 : update build files #
Depends on Patchset: Messages
Total messages: 21 (12 generated)
tommi@webrtc.org changed reviewers: + perkj@webrtc.org
Hej Per - I took a look at why bind.h was in rtc_base, since we were talking about it. Turns out it should be in rtc_base_approved, so this fixes that.
The CQ bit was checked by tommi@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911403002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Move bind.h to rtc_base_approved. This is more a correction than a change since bind.h was incorrectly not a part of rtc_base when building with Chromium while still being used (since it's a header file only). The only dependencies that bind.h has, are in rtc_base_approved, so there's no need to restrict usage of it to rtc_base users only. ========== to ========== Move bind.h to rtc_base_approved. This is more a correction than a change since bind.h was incorrectly not a part of rtc_base when building with Chromium while still being used (since it's a header file only). The only dependencies that bind.h has, are in rtc_base_approved, so there's no need to restrict usage of it to rtc_base users only. NOTRY=true TBR=perkj ==========
tbr-ing since this is a cosmetic change to reflect how the file is actually being used.
The CQ bit was checked by tommi@webrtc.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 1803823003 Patch 720001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Description was changed from ========== Move bind.h to rtc_base_approved. This is more a correction than a change since bind.h was incorrectly not a part of rtc_base when building with Chromium while still being used (since it's a header file only). The only dependencies that bind.h has, are in rtc_base_approved, so there's no need to restrict usage of it to rtc_base users only. NOTRY=true TBR=perkj ========== to ========== Move bind.h to rtc_base_approved. This is more a correction than a change since bind.h was incorrectly not a part of rtc_base when building with Chromium while still being used (since it's a header file only). The only dependencies that bind.h has, are in rtc_base_approved, so there's no need to restrict usage of it to rtc_base users only. NOTRY=true TBR=perkj NO_DEPENDENCY_CHECKS=true ==========
The CQ bit was checked by tommi@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911403002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5019)
Description was changed from ========== Move bind.h to rtc_base_approved. This is more a correction than a change since bind.h was incorrectly not a part of rtc_base when building with Chromium while still being used (since it's a header file only). The only dependencies that bind.h has, are in rtc_base_approved, so there's no need to restrict usage of it to rtc_base users only. NOTRY=true TBR=perkj NO_DEPENDENCY_CHECKS=true ========== to ========== Move bind.h to rtc_base_approved. This is more a correction than a change since bind.h was incorrectly not a part of rtc_base when building with Chromium while still being used (since it's a header file only). The only dependencies that bind.h has, are in rtc_base_approved, so there's no need to restrict usage of it to rtc_base users only. NOTRY=true TBR=perkj NO_DEPENDENCY_CHECKS=true Committed: https://chromium.googlesource.com/external/webrtc/+/cc4fddeba87ffa999781ab205... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as cc4fddeba87ffa999781ab205839aebe35e29470 (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== Move bind.h to rtc_base_approved. This is more a correction than a change since bind.h was incorrectly not a part of rtc_base when building with Chromium while still being used (since it's a header file only). The only dependencies that bind.h has, are in rtc_base_approved, so there's no need to restrict usage of it to rtc_base users only. NOTRY=true TBR=perkj NO_DEPENDENCY_CHECKS=true Committed: https://chromium.googlesource.com/external/webrtc/+/cc4fddeba87ffa999781ab205... ========== to ========== Move bind.h to rtc_base_approved. This is more a correction than a change since bind.h was incorrectly not a part of rtc_base when building with Chromium while still being used (since it's a header file only). The only dependencies that bind.h has, are in rtc_base_approved, so there's no need to restrict usage of it to rtc_base users only. NOTRY=true TBR=perkj NO_DEPENDENCY_CHECKS=true Committed: https://crrev.com/cc4fddeba87ffa999781ab205839aebe35e29470 Cr-Commit-Position: refs/heads/master@{#12474} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/cc4fddeba87ffa999781ab205839aebe35e29470 Cr-Commit-Position: refs/heads/master@{#12474} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
