Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1803823003: WIP: TaskQueue (Closed)

Created:
4 years, 9 months ago by tommi
Modified:
4 years, 8 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

WIP: TaskQueue BUG=

Patch Set 1 #

Patch Set 2 : Support for delayed tasks, deterministic destruction done+test. #

Patch Set 3 : More updates for win, one test passing #

Patch Set 4 : Add TLS #

Patch Set 5 : PostTaskAndReply #

Patch Set 6 : Basic windows support done #

Patch Set 7 : Add lambda tests #

Patch Set 8 : Fix non-win build issue #

Patch Set 9 : add gle #

Patch Set 10 : Remove use of deprecated method on Mac and use an alternate approach #

Patch Set 11 : Fix 'last error' issue and include on all platforms #

Patch Set 12 : Include windows header #

Patch Set 13 : Handle corner case in platformthread on windows #

Patch Set 14 : Store context as member, minor updates and rebase. #

Patch Set 15 : Use lambdas instead of TaskWithReply class #

Patch Set 16 : Mark a couple of ctors explicit #

Patch Set 17 : Move QueueContext into the TaskQueue class #

Patch Set 18 : Fix linux build #

Patch Set 19 : Attempt to fix the android build #

Patch Set 20 : pull in libevent #

Patch Set 21 : #define stuff to be able to compile libevent use on Mac #

Patch Set 22 : Actually use and add the libevent build dependency. Start testing on mac for now. #

Patch Set 23 : PostTask for libevent #

Patch Set 24 : Change the PostTaskAndReply approach for libevent #

Patch Set 25 : Implement delayed tasks #

Patch Set 26 : Add missing includes #

Patch Set 27 : Rebase + Fix tsan issue by reordering members #

Patch Set 28 : Keep track of pending timers #

Patch Set 29 : Debug setup_links for android #

Patch Set 30 : Debug setup_links for android2 #

Patch Set 31 : Update a couple of files #

Patch Set 32 : Rebase #

Patch Set 33 : Rebase again #

Patch Set 34 : Make windows specific extension function in PlatformThread, protected. #

Patch Set 35 : Add one more test, enable dispatch on mac again and clean up a few things #

Patch Set 36 : Rebase #

Patch Set 37 : move windows code out to a separate file #

Patch Set 38 : Split remaining implementation into mac, posix and linux #

Patch Set 39 : Split remaining implementation into mac, posix and linux #

Patch Set 40 : Rename _mac and _linux files and manually exclude them for OSn they're not for #

Patch Set 41 : Minor tweaks & format #

Patch Set 42 : Update comments and fix gn file #

Patch Set 43 : Fix gyp error (doh) #

Patch Set 44 : Change Run() to return a bool and add a test for Task reuse #

Patch Set 45 : Change Run() to return a bool and add a test for Task reuse. #

Patch Set 46 : Fix #

Patch Set 47 : fix #

Patch Set 48 : Modify libevent and add new test #

Patch Set 49 : Handle exit on windows despite a full queue #

Patch Set 50 : todo cleanup and compensate for post timing in libevent #

Patch Set 51 : Compensated delay on win64 #

Patch Set 52 : Rebase #

Patch Set 53 : New task queing primitive: TaskQueue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1141 lines, -8 lines) Patch
M webrtc/base/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 2 chunks +17 lines, -0 lines 0 comments Download
M webrtc/base/base.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 2 chunks +19 lines, -0 lines 0 comments Download
M webrtc/base/base_tests.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/base/task_queue.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 1 chunk +178 lines, -0 lines 0 comments Download
A webrtc/base/task_queue_gcd.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 1 chunk +151 lines, -0 lines 0 comments Download
A webrtc/base/task_queue_libevent.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 1 chunk +312 lines, -0 lines 0 comments Download
A + webrtc/base/task_queue_posix.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 1 chunk +22 lines, -8 lines 0 comments Download
A webrtc/base/task_queue_posix.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +40 lines, -0 lines 0 comments Download
A webrtc/base/task_queue_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 1 chunk +219 lines, -0 lines 0 comments Download
A webrtc/base/task_queue_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 1 chunk +182 lines, -0 lines 0 comments Download

Messages

Total messages: 55 (2 generated)
tommi
Support for delayed tasks, deterministic destruction done+test.
4 years, 9 months ago (2016-03-17 08:54:49 UTC) #1
tommi
Add test for multiple posts
4 years, 9 months ago (2016-03-17 16:25:49 UTC) #2
tommi
Prepare build on other platforms
4 years, 9 months ago (2016-03-19 23:52:37 UTC) #3
tommi
More updates for win, one test passing
4 years, 8 months ago (2016-04-14 21:23:38 UTC) #4
tommi
Add TLS
4 years, 8 months ago (2016-04-15 19:22:46 UTC) #5
tommi
PostTaskAndReply
4 years, 8 months ago (2016-04-15 20:07:11 UTC) #6
tommi
Basic windows support done
4 years, 8 months ago (2016-04-15 21:41:19 UTC) #7
tommi
Add lambda tests
4 years, 8 months ago (2016-04-15 21:56:41 UTC) #8
tommi
Fix non-win build issue
4 years, 8 months ago (2016-04-15 22:02:04 UTC) #9
tommi
add gle
4 years, 8 months ago (2016-04-16 05:02:39 UTC) #10
tommi
Remove use of deprecated method on Mac and use an alternate approach
4 years, 8 months ago (2016-04-16 14:02:01 UTC) #11
tommi
Fix 'last error' issue and include on all platforms
4 years, 8 months ago (2016-04-16 14:08:24 UTC) #12
tommi
Include windows header
4 years, 8 months ago (2016-04-16 14:12:25 UTC) #13
tommi
Handle corner case in platformthread on windows
4 years, 8 months ago (2016-04-16 14:25:43 UTC) #14
tommi
Store context as member, minor updates and rebase.
4 years, 8 months ago (2016-04-16 15:19:52 UTC) #15
tommi
Use lambdas instead of TaskWithReply class
4 years, 8 months ago (2016-04-16 17:11:56 UTC) #16
tommi
Mark a couple of ctors explicit
4 years, 8 months ago (2016-04-16 17:23:20 UTC) #17
tommi
Move QueueContext into the TaskQueue class
4 years, 8 months ago (2016-04-16 17:27:19 UTC) #18
tommi
Fix linux build
4 years, 8 months ago (2016-04-16 17:35:26 UTC) #19
tommi
Attempt to fix the android build
4 years, 8 months ago (2016-04-16 17:51:17 UTC) #20
tommi
pull in libevent
4 years, 8 months ago (2016-04-16 21:39:03 UTC) #21
tommi
#define stuff to be able to compile libevent use on Mac
4 years, 8 months ago (2016-04-19 09:28:11 UTC) #22
tommi
Actually use and add the libevent build dependency. Start testing on mac for now.
4 years, 8 months ago (2016-04-19 13:13:38 UTC) #23
tommi
PostTask for libevent
4 years, 8 months ago (2016-04-20 14:23:40 UTC) #24
tommi
Change the PostTaskAndReply approach for libevent
4 years, 8 months ago (2016-04-21 16:14:55 UTC) #25
tommi
Implement delayed tasks
4 years, 8 months ago (2016-04-21 16:35:39 UTC) #26
tommi
Add missing includes
4 years, 8 months ago (2016-04-21 16:40:56 UTC) #27
tommi
Rebase + Fix tsan issue by reordering members
4 years, 8 months ago (2016-04-21 17:54:08 UTC) #28
tommi
Keep track of pending timers
4 years, 8 months ago (2016-04-21 21:21:01 UTC) #29
tommi
Debug setup_links for android
4 years, 8 months ago (2016-04-21 21:45:23 UTC) #30
tommi
Debug setup_links for android2
4 years, 8 months ago (2016-04-21 21:55:47 UTC) #31
tommi
Update a couple of files
4 years, 8 months ago (2016-04-22 07:51:40 UTC) #32
tommi
Rebase
4 years, 8 months ago (2016-04-22 08:46:42 UTC) #33
tommi
Rebase again
4 years, 8 months ago (2016-04-22 08:51:32 UTC) #34
tommi
Make windows specific extension function in PlatformThread, protected.
4 years, 8 months ago (2016-04-22 12:48:34 UTC) #35
tommi
Add one more test, enable dispatch on mac again and clean up a few things
4 years, 8 months ago (2016-04-22 15:21:55 UTC) #36
tommi
Rebase
4 years, 8 months ago (2016-04-22 16:09:49 UTC) #39
tommi
move windows code out to a separate file
4 years, 8 months ago (2016-04-22 17:09:24 UTC) #40
tommi
Split remaining implementation into mac, posix and linux
4 years, 8 months ago (2016-04-22 19:19:56 UTC) #41
tommi
Split remaining implementation into mac, posix and linux
4 years, 8 months ago (2016-04-22 19:20:40 UTC) #42
tommi
Rename _mac and _linux files and manually exclude them for OSn they're not for
4 years, 8 months ago (2016-04-22 19:51:34 UTC) #43
tommi
Minor tweaks & format
4 years, 8 months ago (2016-04-22 20:12:47 UTC) #44
tommi
Update comments and fix gn file
4 years, 8 months ago (2016-04-22 20:32:23 UTC) #45
tommi
Fix gyp error (doh)
4 years, 8 months ago (2016-04-22 20:37:53 UTC) #46
tommi
Change Run() to return a bool and add a test for Task reuse
4 years, 8 months ago (2016-04-23 14:54:03 UTC) #47
tommi
Change Run() to return a bool and add a test for Task reuse.
4 years, 8 months ago (2016-04-23 15:00:46 UTC) #48
tommi
Fix
4 years, 8 months ago (2016-04-23 16:01:53 UTC) #49
tommi
fix
4 years, 8 months ago (2016-04-23 16:18:20 UTC) #50
tommi
Modify libevent and add new test
4 years, 8 months ago (2016-04-23 21:43:16 UTC) #51
tommi
Handle exit on windows despite a full queue
4 years, 8 months ago (2016-04-23 22:03:45 UTC) #52
tommi
todo cleanup and compensate for post timing in libevent
4 years, 8 months ago (2016-04-24 07:08:05 UTC) #53
tommi
Compensated delay on win64
4 years, 8 months ago (2016-04-24 08:27:11 UTC) #54
tommi
4 years, 8 months ago (2016-04-24 22:08:55 UTC) #55 
Rebase

Powered by Google App Engine
This is Rietveld 408576698