Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1910423002: Revert of Update histogram "WebRTC.Video.OnewayDelayInMs" to use the estimated one-way delay. (patc… (Closed)

Created:
4 years, 8 months ago by åsapersson
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@51
Target Ref:
refs/pending/branch-heads/51
Project:
webrtc
Visibility:
Public.

Description

Revert of Update histogram "WebRTC.Video.OnewayDelayInMs" to use the estimated one-way delay. (patchset #4 id:60001 of https://codereview.webrtc.org/1688143003/ ) Reason for revert: The delay stats are high. Original issue's description: > Update histogram "WebRTC.Video.OnewayDelayInMs" to use the estimated one-way delay. > Previous logged delay was: network delay (rtt/2) + jitter delay + decode time + render delay. > > Make capture time in local timebase available for decoded VP9 video frames (propagate ntp_time_ms from EncodedImage to decoded VideoFrame). > > BUG= > > Committed: https://crrev.com/5249599a9b69ad9c2d513210d694719f1011f977 > Cr-Commit-Position: refs/heads/master@{#11901} TBR=stefan@webrtc.org,pbos@webrtc.org BUG=chromium:603838 Review URL: https://codereview.webrtc.org/1893543003 Cr-Commit-Position: refs/heads/master@{#12400} (cherry picked from commit a186288fd0ab5dfc7a1306e7a72b8872230bfdb5) Committed: https://chromium.googlesource.com/external/webrtc/+/8ec8471f8b72ca54af9d923d1af48a041c115f1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910423002/1
4 years, 8 months ago (2016-04-22 11:25:48 UTC) #2
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 8 months ago (2016-04-22 11:25:49 UTC) #4
åsapersson
4 years, 8 months ago (2016-04-22 11:27:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8ec8471f8b72ca54af9d923d1af48a041c115f1a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698