Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1893543003: Revert of Update histogram "WebRTC.Video.OnewayDelayInMs" to use the estimated one-way delay. (Closed)

Created:
4 years, 8 months ago by åsapersson
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Update histogram "WebRTC.Video.OnewayDelayInMs" to use the estimated one-way delay. (patchset #4 id:60001 of https://codereview.webrtc.org/1688143003/ ) Reason for revert: The delay stats are high. Original issue's description: > Update histogram "WebRTC.Video.OnewayDelayInMs" to use the estimated one-way delay. > Previous logged delay was: network delay (rtt/2) + jitter delay + decode time + render delay. > > Make capture time in local timebase available for decoded VP9 video frames (propagate ntp_time_ms from EncodedImage to decoded VideoFrame). > > BUG= > > Committed: https://crrev.com/5249599a9b69ad9c2d513210d694719f1011f977 > Cr-Commit-Position: refs/heads/master@{#11901} TBR=stefan@webrtc.org,pbos@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:603838 Committed: https://crrev.com/a186288fd0ab5dfc7a1306e7a72b8872230bfdb5 Cr-Commit-Position: refs/heads/master@{#12400}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 3 chunks +4 lines, -9 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
åsapersson
Created Revert of Update histogram "WebRTC.Video.OnewayDelayInMs" to use the estimated one-way delay.
4 years, 8 months ago (2016-04-15 10:06:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893543003/1
4 years, 8 months ago (2016-04-15 10:06:48 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_arm64_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/9020) ios_arm64_rel on tryserver.webrtc (JOB_FAILED, ...
4 years, 8 months ago (2016-04-15 10:09:14 UTC) #5
pbos-webrtc
lgtm
4 years, 8 months ago (2016-04-15 12:01:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893543003/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893543003/170001
4 years, 8 months ago (2016-04-15 12:04:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 8 months ago (2016-04-15 12:44:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893543003/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893543003/170001
4 years, 8 months ago (2016-04-18 06:42:43 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:170001)
4 years, 8 months ago (2016-04-18 07:41:09 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 07:41:15 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a186288fd0ab5dfc7a1306e7a72b8872230bfdb5
Cr-Commit-Position: refs/heads/master@{#12400}

Powered by Google App Engine
This is Rietveld 408576698