Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1909593002: Cleanup webrtc/modules/desktop_capture (Closed)

Created:
4 years, 8 months ago by Sergey Ulanov
Modified:
4 years, 8 months ago
Reviewers:
Jamie
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Cleanup webrtc/modules/desktop_capture Removed deprecated files, types and methods in modules/webrtc that were kept there to avoid breaking chromium, and which are no longer needed. BUG=172183 Committed: https://crrev.com/6acd9f49d9b3038d3718ab36e99438cba45ec3a1 Cr-Commit-Position: refs/heads/master@{#12457}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -133 lines) Patch
M webrtc/modules/desktop_capture/BUILD.gn View 1 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_capture.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_capturer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_frame_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
D webrtc/modules/desktop_capture/mouse_cursor_shape.h View 1 chunk +0 lines, -17 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer.h View 1 chunk +1 line, -25 lines 0 comments Download
D webrtc/modules/desktop_capture/screen_capturer.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mac_unittest.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer.h View 1 chunk +0 lines, -3 lines 0 comments Download
D webrtc/modules/desktop_capture/window_capturer.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Sergey Ulanov
4 years, 8 months ago (2016-04-20 17:43:50 UTC) #4
Jamie
lgtm https://codereview.chromium.org/1909593002/diff/1/webrtc/modules/desktop_capture/screen_capturer.h File webrtc/modules/desktop_capture/screen_capturer.h (left): https://codereview.chromium.org/1909593002/diff/1/webrtc/modules/desktop_capture/screen_capturer.h#oldcode61 webrtc/modules/desktop_capture/screen_capturer.h:61: // crbug.com/172183 Should you add a BUG= line ...
4 years, 8 months ago (2016-04-20 18:38:41 UTC) #5
Sergey Ulanov
https://codereview.chromium.org/1909593002/diff/1/webrtc/modules/desktop_capture/screen_capturer.h File webrtc/modules/desktop_capture/screen_capturer.h (left): https://codereview.chromium.org/1909593002/diff/1/webrtc/modules/desktop_capture/screen_capturer.h#oldcode61 webrtc/modules/desktop_capture/screen_capturer.h:61: // crbug.com/172183 On 2016/04/20 18:38:40, Jamie wrote: > Should ...
4 years, 8 months ago (2016-04-20 18:45:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909593002/1
4 years, 8 months ago (2016-04-20 21:03:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn_rel/builds/10261) mac_asan on tryserver.webrtc (JOB_FAILED, ...
4 years, 8 months ago (2016-04-20 21:05:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909593002/20001
4 years, 8 months ago (2016-04-20 21:11:45 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-20 23:12:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909593002/20001
4 years, 8 months ago (2016-04-21 16:40:25 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 16:46:26 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 17:04:53 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6acd9f49d9b3038d3718ab36e99438cba45ec3a1
Cr-Commit-Position: refs/heads/master@{#12457}

Powered by Google App Engine
This is Rietveld 408576698