webrtc/modules/desktop_capture/desktop_frame_win.cc - Issue 1909593002: Cleanup webrtc/modules/desktop_capture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/desktop_capture/desktop_frame_win.cc

Issue 1909593002: Cleanup webrtc/modules/desktop_capture (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/desktop_capture/desktop_frame_win.cc

diff --git a/webrtc/modules/desktop_capture/desktop_frame_win.cc b/webrtc/modules/desktop_capture/desktop_frame_win.cc

index f139fb5cddf2bb7ea2b71a668fddb940b23441c0..e91e37eb5ae20e464a5e2af01e4c99c54341e696 100644

--- a/webrtc/modules/desktop_capture/desktop_frame_win.cc

+++ b/webrtc/modules/desktop_capture/desktop_frame_win.cc

@@ -51,8 +51,7 @@ DesktopFrameWin* DesktopFrameWin::Create(

if (shared_memory_factory) {

shared_memory = rtc::ScopedToUnique(

shared_memory_factory->CreateSharedMemory(buffer_size));

- if (shared_memory)

- section_handle = shared_memory->handle();

+ section_handle = shared_memory->handle();

}

void* data = nullptr;

HBITMAP bitmap = CreateDIBSection(hdc, &bmi, DIB_RGB_COLORS, &data,