Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 1908373002: Update PlatformThread to support a couple of new properties. (Closed)

Created:
4 years, 8 months ago by tommi
Modified:
4 years, 8 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update PlatformThread to support a couple of new properties. - name(): Returns the name of the thread (useful for debugging). - GetThreadRef(): Returns the ID of the worker thread (also useful for debugging). - QueueApc(): This is a Windows-only, protected function that allows derived classes on Windows to queue APCs to the worker thread. NOTRY=true (using notry since the patch has already passed the trybots and the cq is currently stalled) Committed: https://crrev.com/845afa8a0212200469e7a11f4fe45ba4a22a36d2 Cr-Commit-Position: refs/heads/master@{#12472}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add one more test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -17 lines) Patch
M webrtc/base/platform_thread.h View 2 chunks +13 lines, -0 lines 0 comments Download
M webrtc/base/platform_thread.cc View 6 chunks +26 lines, -4 lines 0 comments Download
M webrtc/base/platform_thread_unittest.cc View 1 2 chunks +28 lines, -13 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
tommi
4 years, 8 months ago (2016-04-22 13:11:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908373002/1
4 years, 8 months ago (2016-04-22 13:11:32 UTC) #4
perkj_webrtc
lgtm with a request https://codereview.webrtc.org/1908373002/diff/1/webrtc/base/platform_thread_unittest.cc File webrtc/base/platform_thread_unittest.cc (right): https://codereview.webrtc.org/1908373002/diff/1/webrtc/base/platform_thread_unittest.cc#newcode42 webrtc/base/platform_thread_unittest.cc:42: } To show the usage- ...
4 years, 8 months ago (2016-04-22 13:32:20 UTC) #5
tommi
Add one more test
4 years, 8 months ago (2016-04-22 14:46:27 UTC) #6
tommi
https://codereview.webrtc.org/1908373002/diff/1/webrtc/base/platform_thread_unittest.cc File webrtc/base/platform_thread_unittest.cc (right): https://codereview.webrtc.org/1908373002/diff/1/webrtc/base/platform_thread_unittest.cc#newcode42 webrtc/base/platform_thread_unittest.cc:42: } On 2016/04/22 13:32:20, perkj_webrtc wrote: > To show ...
4 years, 8 months ago (2016-04-22 14:47:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908373002/20001
4 years, 8 months ago (2016-04-22 14:47:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908373002/20001
4 years, 8 months ago (2016-04-22 16:06:49 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 16:08:49 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 16:38:22 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/845afa8a0212200469e7a11f4fe45ba4a22a36d2
Cr-Commit-Position: refs/heads/master@{#12472}

Powered by Google App Engine
This is Rietveld 408576698