Update PlatformThread to support a couple of new properties.

webrtc/base/platform_thread_unittest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/base/platform_thread.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "webrtc/base/scoped_ptr.h"
 #include "webrtc/system_wrappers/include/sleep.h"
 
-namespace webrtc {
-
+namespace rtc {
+namespace {
 // Function that does nothing, and reports success.
 bool NullRunFunction(void* obj) {
-  SleepMs(0);  // Hand over timeslice, prevents busy looping.
+  webrtc::SleepMs(0);  // Hand over timeslice, prevents busy looping.
   return true;
 }
 
-TEST(PlatformThreadTest, StartStop) {
-  rtc::PlatformThread thread(&NullRunFunction, nullptr, "PlatformThreadTest");
-  thread.Start();
-  thread.Stop();
-}
-
 // Function that sets a boolean.
 bool SetFlagRunFunction(void* obj) {
   bool* obj_as_bool = static_cast<bool*>(obj);
   *obj_as_bool = true;
-  SleepMs(0);  // Hand over timeslice, prevents busy looping.
+  webrtc::SleepMs(0);  // Hand over timeslice, prevents busy looping.
   return true;
 }
+}  // namespace
+
+TEST(PlatformThreadTest, StartStop) {
+  PlatformThread thread(&NullRunFunction, nullptr, "PlatformThreadTest");
+  EXPECT_TRUE(thread.name() == "PlatformThreadTest");
+  EXPECT_TRUE(thread.GetThreadRef() == 0);
+  thread.Start();
+  EXPECT_TRUE(thread.GetThreadRef() != 0);
+  thread.Stop();
+  EXPECT_TRUE(thread.GetThreadRef() == 0);
+}

[perkj_webrtc, 2016/04/22 13:32:20]

To show the usage- can you add another test with two threads that check
thread1.GetThreadRef() != thread2.GetThreadRef()

[tommi, 2016/04/22 14:47:11]

Done.

 
 TEST(PlatformThreadTest, RunFunctionIsCalled) {
   bool flag = false;
-  rtc::PlatformThread thread(&SetFlagRunFunction, &flag, "RunFunctionIsCalled");
+  PlatformThread thread(&SetFlagRunFunction, &flag, "RunFunctionIsCalled");
   thread.Start();
 
   // At this point, the flag may be either true or false.
   thread.Stop();
 
   // We expect the thread to have run at least once.
   EXPECT_TRUE(flag);
 }
-
-}  // namespace webrtc
+}  // rtc