Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Unified Diff: webrtc/api/dtlsidentitystore_unittest.cc

Issue 1907083005: Stop preemptively generating an RSA key pair. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixing bug where an extra identity is generated. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/dtlsidentitystore.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/dtlsidentitystore_unittest.cc
diff --git a/webrtc/api/dtlsidentitystore_unittest.cc b/webrtc/api/dtlsidentitystore_unittest.cc
index 809e885216c2c4edcfe409064b470f9be18687c0..65428f2edf38dd292fd04545964b0feb8b15207b 100644
--- a/webrtc/api/dtlsidentitystore_unittest.cc
+++ b/webrtc/api/dtlsidentitystore_unittest.cc
@@ -83,8 +83,6 @@ class DtlsIdentityStoreTest : public testing::Test {
};
TEST_F(DtlsIdentityStoreTest, RequestIdentitySuccessRSA) {
- EXPECT_TRUE_WAIT(store_->HasFreeIdentityForTesting(rtc::KT_RSA), kTimeoutMs);
-
store_->RequestIdentity(rtc::KeyParams(rtc::KT_RSA),
rtc::Optional<uint64_t>(),
observer_.get());
@@ -103,14 +101,14 @@ TEST_F(DtlsIdentityStoreTest, RequestIdentitySuccessRSA) {
}
TEST_F(DtlsIdentityStoreTest, RequestIdentitySuccessECDSA) {
- // Since store currently does not preemptively generate free ECDSA identities
- // we do not invoke HasFreeIdentityForTesting between requests.
-
store_->RequestIdentity(rtc::KeyParams(rtc::KT_ECDSA),
rtc::Optional<uint64_t>(),
observer_.get());
EXPECT_TRUE_WAIT(observer_->LastRequestSucceeded(), kTimeoutMs);
+ // Since store currently does not preemptively generate free ECDSA identities
+ // we do not invoke HasFreeIdentityForTesting between requests.
+
observer_->Reset();
// Verifies that the callback is async when a free identity is ready.
« no previous file with comments | « webrtc/api/dtlsidentitystore.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698