Stop preemptively generating an RSA key pair.

webrtc/api/dtlsidentitystore_unittest.cc

 /*
  *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 65 matching lines @@
   static void TearDownTestCase() {
     rtc::CleanupSSL();
   }
 
   rtc::scoped_ptr<rtc::Thread> worker_thread_;
   rtc::scoped_ptr<DtlsIdentityStoreImpl> store_;
   rtc::scoped_refptr<MockDtlsIdentityRequestObserver> observer_;
 };
 
 TEST_F(DtlsIdentityStoreTest, RequestIdentitySuccessRSA) {
-  EXPECT_TRUE_WAIT(store_->HasFreeIdentityForTesting(rtc::KT_RSA), kTimeoutMs);
-
   store_->RequestIdentity(rtc::KeyParams(rtc::KT_RSA),
                           rtc::Optional<uint64_t>(),
                           observer_.get());
   EXPECT_TRUE_WAIT(observer_->LastRequestSucceeded(), kTimeoutMs);
 
   EXPECT_TRUE_WAIT(store_->HasFreeIdentityForTesting(rtc::KT_RSA), kTimeoutMs);
 
   observer_->Reset();
 
   // Verifies that the callback is async when a free identity is ready.
   store_->RequestIdentity(rtc::KeyParams(rtc::KT_RSA),
                           rtc::Optional<uint64_t>(),
                           observer_.get());
   EXPECT_FALSE(observer_->call_back_called());
   EXPECT_TRUE_WAIT(observer_->LastRequestSucceeded(), kTimeoutMs);
 }
 
 TEST_F(DtlsIdentityStoreTest, RequestIdentitySuccessECDSA) {
-  // Since store currently does not preemptively generate free ECDSA identities
-  // we do not invoke HasFreeIdentityForTesting between requests.
-
   store_->RequestIdentity(rtc::KeyParams(rtc::KT_ECDSA),
                           rtc::Optional<uint64_t>(),
                           observer_.get());
   EXPECT_TRUE_WAIT(observer_->LastRequestSucceeded(), kTimeoutMs);
 
+  // Since store currently does not preemptively generate free ECDSA identities
+  // we do not invoke HasFreeIdentityForTesting between requests.
+
   observer_->Reset();
 
   // Verifies that the callback is async when a free identity is ready.
   store_->RequestIdentity(rtc::KeyParams(rtc::KT_ECDSA),
                           rtc::Optional<uint64_t>(),
                           observer_.get());
   EXPECT_FALSE(observer_->call_back_called());
   EXPECT_TRUE_WAIT(observer_->LastRequestSucceeded(), kTimeoutMs);
 }
 
@@ skipping 14 matching lines @@
 
   store_->RequestIdentity(rtc::KeyParams(rtc::KT_ECDSA),
                           rtc::Optional<uint64_t>(),
                           observer_.get());
   store_.reset();
 
   worker_thread_->Stop();
   EXPECT_FALSE(observer_->call_back_called());
 }