Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 1905563002: Add histogram for end-to-end delay. (Closed)

Created:
4 years, 8 months ago by åsapersson
Modified:
4 years, 3 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add histogram for end-to-end delay: "WebRTC.Video.EndToEndDelayInMs" Make capture time in local timebase available for decoded VP9 video frames (propagate ntp_time_ms from EncodedImage to decoded VideoFrame). BUG=webrtc:6409 Committed: https://crrev.com/1490f7aa55919d5f501e31f9aac844a80255be81 Cr-Commit-Position: refs/heads/master@{#14367}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Total comments: 3

Patch Set 4 : rebase + add separate histogram for end-to-end delay #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7 lines) Patch
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 2 3 3 chunks +13 lines, -2 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
åsapersson
https://codereview.webrtc.org/1905563002/diff/40001/webrtc/video/receive_statistics_proxy.cc File webrtc/video/receive_statistics_proxy.cc (right): https://codereview.webrtc.org/1905563002/diff/40001/webrtc/video/receive_statistics_proxy.cc#newcode191 webrtc/video/receive_statistics_proxy.cc:191: current_delay_counter_.Add(current_delay_ms); Should we let target delay replace this metric ...
4 years, 7 months ago (2016-04-28 07:42:19 UTC) #3
mflodman
https://codereview.webrtc.org/1905563002/diff/40001/webrtc/video/receive_statistics_proxy.cc File webrtc/video/receive_statistics_proxy.cc (right): https://codereview.webrtc.org/1905563002/diff/40001/webrtc/video/receive_statistics_proxy.cc#newcode191 webrtc/video/receive_statistics_proxy.cc:191: current_delay_counter_.Add(current_delay_ms); On 2016/04/28 07:42:18, åsapersson wrote: > Should we ...
4 years, 7 months ago (2016-05-06 08:23:42 UTC) #4
åsapersson
https://codereview.webrtc.org/1905563002/diff/40001/webrtc/video/receive_statistics_proxy.cc File webrtc/video/receive_statistics_proxy.cc (right): https://codereview.webrtc.org/1905563002/diff/40001/webrtc/video/receive_statistics_proxy.cc#newcode191 webrtc/video/receive_statistics_proxy.cc:191: current_delay_counter_.Add(current_delay_ms); On 2016/05/06 08:23:42, mflodman wrote: > On 2016/04/28 ...
4 years, 3 months ago (2016-09-22 12:23:08 UTC) #7
mflodman
lgtm
4 years, 3 months ago (2016-09-23 08:08:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/1905563002/60001
4 years, 3 months ago (2016-09-23 08:16:48 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-23 09:09:49 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 09:10:11 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1490f7aa55919d5f501e31f9aac844a80255be81
Cr-Commit-Position: refs/heads/master@{#14367}

Powered by Google App Engine
This is Rietveld 408576698