Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1901593002: Fixed memleak when two voip blocks present in single rtcp packet. (Closed)

Created:
4 years, 8 months ago by danilchap
Modified:
4 years, 8 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixed memleak when two voip blocks present in single rtcp packet. BUG=chromium:603894 Committed: https://crrev.com/d6b851a1bd197fcf1f2d8183b6f86a92d5d8ee17 Cr-Commit-Position: refs/heads/master@{#12413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
danilchap
4 years, 8 months ago (2016-04-18 08:01:35 UTC) #2
åsapersson
lgtm
4 years, 8 months ago (2016-04-18 14:40:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901593002/1
4 years, 8 months ago (2016-04-18 14:56:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
4 years, 8 months ago (2016-04-18 16:57:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901593002/1
4 years, 8 months ago (2016-04-18 17:40:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 17:54:08 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 17:54:19 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d6b851a1bd197fcf1f2d8183b6f86a92d5d8ee17
Cr-Commit-Position: refs/heads/master@{#12413}

Powered by Google App Engine
This is Rietveld 408576698