webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h - Issue 1901593002: Fixed memleak when two voip blocks present in single rtcp packet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h

Issue 1901593002: Fixed memleak when two voip blocks present in single rtcp packet. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h b/webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h

index a79284196272ae7a37d21c20e927e7a93aba3871..da578c7ff90386e18c3615f22b5964944e67f38e 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h

@@ -12,6 +12,7 @@

#define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_RECEIVER_HELP_H_

#include <list>

+#include <memory>

#include <vector>

#include "webrtc/base/constructormagic.h"

@@ -87,7 +88,7 @@ public:

uint32_t xr_originator_ssrc;

bool xr_dlrr_item;

- RTCPVoIPMetric* VoIPMetric;

+ std::unique_ptr<RTCPVoIPMetric> VoIPMetric;

rtc::scoped_ptr<rtcp::TransportFeedback> transport_feedback_;

« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.cc » ('j') | no next file with comments »