Delete unused methods of the VideoProcessing class. And fix a typo.

Delete unused methods of the VideoProcessing class. And fix a typo.

Rename EnableDenosing --> EnableDenoising.
Delete VideoProcessing FrameStats methods.
Delete VideoProcessingImpl::BrightnessDetection and related files.
Delete VideoProcessingImpl::Deflickering and related files.
Delete VideoProcessing::Brighten.

BUG=

Committed: https://crrev.com/90c335a100d5a99690c05fe76b45f8689d3f0d76
Cr-Commit-Position: refs/heads/master@{#12521}

[nisse-webrtc, 2016-04-20 13:35:09]

nisse@webrtc.org changed reviewers:
+ pbos@webrtc.org, stefan@webrtc.org

[nisse-webrtc, 2016-04-20 13:35:10]

Please also have a look in at the deleted tests. It's unclear to me what some of
them, in particular IdenticalResultsAfterReset, was supposed to be testing, and
if maybe it should be tested in some other way.

[pbos-webrtc, 2016-04-24 18:19:42]

lgtm, I like that FrameStats went away too

https://codereview.webrtc.org/1901393003/diff/1/webrtc/modules/video_processi...
File webrtc/modules/video_processing/video_processing_impl.h (right):

https://codereview.webrtc.org/1901393003/diff/1/webrtc/modules/video_processi...
webrtc/modules/video_processing/video_processing_impl.h:42: rtc::CriticalSection
mutex_;
Does this guard anything anymore? If so annotate it, otherwise remove mutex_.

[nisse-webrtc, 2016-04-25 06:42:34]

https://codereview.webrtc.org/1901393003/diff/1/webrtc/modules/video_processi...
File webrtc/modules/video_processing/video_processing_impl.h (right):

https://codereview.webrtc.org/1901393003/diff/1/webrtc/modules/video_processi...
webrtc/modules/video_processing/video_processing_impl.h:42: rtc::CriticalSection
mutex_;
On 2016/04/24 18:19:42, pbos-webrtc wrote:
> Does this guard anything anymore? If so annotate it, otherwise remove mutex_.

It protects the frame_pre_processor_. In fact, what's left of this class is the
mutex and delegation of all methods to that object.

I'm adding a GUARDED_BY annotation.

[stefan-webrtc, 2016-04-26 11:11:51]

lgtm

[nisse-webrtc, 2016-04-27 06:56:38]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-04-27 06:56:39]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1901393003/#ps20001 (title:
"Added GUARDED_BY annotation.")

[commit-bot: I haz the power, 2016-04-27 06:56:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901393003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901393003/20001

[commit-bot: I haz the power, 2016-04-27 07:59:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-27 07:59:33]

Description was changed from

==========
Delete unused methods of the VideoProcessing class. And fix a typo.

Rename EnableDenosing --> EnableDenoising.
Delete VideoProcessing FrameStats methods.
Delete VideoProcessingImpl::BrightnessDetection and related files.
Delete VideoProcessingImpl::Deflickering and related files.
Delete VideoProcessing::Brighten.

BUG=
==========

to

==========
Delete unused methods of the VideoProcessing class. And fix a typo.

Rename EnableDenosing --> EnableDenoising.
Delete VideoProcessing FrameStats methods.
Delete VideoProcessingImpl::BrightnessDetection and related files.
Delete VideoProcessingImpl::Deflickering and related files.
Delete VideoProcessing::Brighten.

BUG=

Committed: https://crrev.com/90c335a100d5a99690c05fe76b45f8689d3f0d76
Cr-Commit-Position: refs/heads/master@{#12521}
==========

[commit-bot: I haz the power, 2016-04-27 07:59:34]

Patchset 2 (id:??) landed as
https://crrev.com/90c335a100d5a99690c05fe76b45f8689d3f0d76
Cr-Commit-Position: refs/heads/master@{#12521}